From: tony@atomide.com
To: Tim Bird <tim.bird@am.sony.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] support printk-times by fixing sched_clock to be callable in early boot
Date: Tue, 5 Sep 2006 18:37:11 +0300 [thread overview]
Message-ID: <20060905153710.GD18073@atomide.com> (raw)
In-Reply-To: <44ECA01B.7000408@am.sony.com>
Hi,
* Tim Bird <tim.bird@am.sony.com> [060823 21:37]:
> Hi all,
>
> This patch has been sitting in my 'to-submit' queue for a long time.
>
> Basically, you can't use the printk times feature on omap, because
> by default it calls sched_clock() before the timer is set up, which
> causes the machine to hang. This simplistic fix makes sched_clock()
> return 0 until the clock has been properly initialized.
>
> The overhead of the flag check is not big, but it's impact could
> be reduced by moving the test into a separate printk_clock()
> routine (which would front the sched_clock() function, and
> is only called by printk when printk timing is active.)
> Let me know if you would prefer that I rework this patch to
> use that approach instead.
Sorry for the long delay in replying. Let's rather implement
printk_clock() like you suggest as sched_clock is called quite a bit.
That should also allow us to remove the current hack
e4fb3a282725bc66dc63fd248e9d05e0396ddf95 in kernel/printk.c.
Regards,
Tony
prev parent reply other threads:[~2006-09-05 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 18:36 [PATCH] support printk-times by fixing sched_clock to be callable in early boot Tim Bird
2006-09-05 15:37 ` tony [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060905153710.GD18073@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox