Re: [PATCH] OMAP audio DMA changes for 310 CPUs

andrzej zaborowski
2006-08-19T00:12:03Z

Hi,

On 18/08/06, lamikr <lamikr@cc.jyu.fi> wrote:
> Hi andrzej
>
> I have couple of questions from your patch.
> Your patch has couple of these changes where cpu_is_omap1510() has been
> changed to cpu_is_omap15xx().
> - if (!cpu_is_omap1510())
> + if (!cpu_is_omap15xx())
>
> Do they affect to the sound in omap 310? (I mean is cpu_is_omap15xx()
> true for your omap310)

Yes, from what I've seen cpu_is_omap15xx() is always cpu_is_omap1510()
|| cpu_is_omap310() and it makes sense because the processors are
mostly compatible (with little exceptions). Similarly
CONFIG_ARCH_OMAP15XX.

> Or is following the only relevant omap310 specific change
>
> + } else if (cpu_is_omap310())
> + omap_start_dma(channel);
>
> Btw, your patch will not apply on top of all 5 patches I sent.

Oops. I will resend. (but can't do it now)

> Could you perhaps re-send it one more time? (I need also test whether
> your changes could work with omap1510/h6300)

They shouldn't affect omap1510.

>
> Mika
>
> andrzej zaborowski wrote:
> > Avoid restarting McBSP hardware after every DMA transfer to OMAP audio
> > devices on OMAP310, restart only DMA. Also avoid trying to link DMA
> > channels together as this feature isn't supported on 310 processors.
> > Apply on top of "[PATCH 1/5] Change all omap15xx devices to use
> > similar DMA handling than h6300 uses".
> >
> > Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > Linux-omap-open-source mailing list
> > Linux-omap-open-source@linux.omap.com
> > http://linux.omap.com/mailman/listinfo/linux-omap-open-source
> >
>
>

--
balrog 2oo6

Dear Outlook users: Please remove me from your address books