Re: [PATCH] OMAP audio DMA changes for 310 CPUs

lamikr
2006-08-18T17:07:26Z

Hi andrzej

I have couple of questions from your patch.
Your patch has couple of these changes where cpu_is_omap1510() has been
changed to cpu_is_omap15xx().
- if (!cpu_is_omap1510())
+ if (!cpu_is_omap15xx())

Do they affect to the sound in omap 310? (I mean is cpu_is_omap15xx()
true for your omap310)
Or is following the only relevant omap310 specific change

+ } else if (cpu_is_omap310())
+ omap_start_dma(channel);

Btw, your patch will not apply on top of all 5 patches I sent.
Could you perhaps re-send it one more time? (I need also test whether
your changes could work with omap1510/h6300)

Mika

andrzej zaborowski wrote:
> Avoid restarting McBSP hardware after every DMA transfer to OMAP audio
> devices on OMAP310, restart only DMA. Also avoid trying to link DMA
> channels together as this feature isn't supported on 310 processors.
> Apply on top of "[PATCH 1/5] Change all omap15xx devices to use
> similar DMA handling than h6300 uses".
>
> Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Linux-omap-open-source mailing list
> Linux-omap-open-source@linux.omap.com
> http://linux.omap.com/mailman/listinfo/linux-omap-open-source
>