Re: Disable DSPGW fails

[Marcin Juszkiewicz <openembedded@hrw.one.pl>]

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

Dnia środa, 4 października 2006 10:47, Dirk Behme napisał:

> while debugging the OSK issue, I tried to disable DSPGW
> completely (CONFIG_OMAP_DSP is not set). On most recent git
> this fails with
>
> arch/arm/plat-omap/built-in.o: In function `omap_mcbsp_free':
> mcbsp.c:(.text+0x44b8): undefined reference to
> `omap_dsp_release_mem'
> arch/arm/plat-omap/built-in.o: In function `omap_mcbsp_request':
> mcbsp.c:(.text+0x45cc): undefined reference to
> `omap_dsp_request_mem'
>
> Anybody with an idea how to fix this?

Attached patch fix it. Feel free to push it into correct maintainer to get 
it included in GIT tree.

-- 
JID: hrw-jabber.org
OpenEmbedded developer

             Today is the first day of the rest of your life.

[-- Attachment #2: linux-omap-no-dsp-fix.patch --]
[-- Type: text/x-diff, Size: 1345 bytes --]


while debugging the OSK issue, I tried to disable DSPGW 
completely (CONFIG_OMAP_DSP is not set). 

On most recent git this fails with

arch/arm/plat-omap/built-in.o: In function `omap_mcbsp_free':
mcbsp.c:(.text+0x44b8): undefined reference to 
`omap_dsp_release_mem'
arch/arm/plat-omap/built-in.o: In function `omap_mcbsp_request':
mcbsp.c:(.text+0x45cc): undefined reference to 
`omap_dsp_request_mem'

This patch fixes it.

Signed-off-by: Marcin Juszkiewicz <openembedded@hrw.one.pl>


Index: git/arch/arm/plat-omap/mcbsp.c
===================================================================
--- git.orig/arch/arm/plat-omap/mcbsp.c 2006-09-27 12:17:21.000000000 +0200
+++ git/arch/arm/plat-omap/mcbsp.c      2006-09-27 12:17:01.000000000 +0200
@@ -197,7 +197,9 @@
 static void omap_mcbsp_dsp_request(void)
 {
        if (cpu_is_omap15xx() || cpu_is_omap16xx()) {
+#ifdef CONFIG_OMAP_DSP
                omap_dsp_request_mem();
+#endif
                clk_enable(mcbsp_dsp_ck);
                clk_enable(mcbsp_api_ck);

@@ -216,7 +218,9 @@
 static void omap_mcbsp_dsp_free(void)
 {
        if (cpu_is_omap15xx() || cpu_is_omap16xx()) {
+#ifdef CONFIG_OMAP_DSP
                omap_dsp_release_mem();
+#endif
                clk_disable(mcbsp_dspxor_ck);
                clk_disable(mcbsp_dsp_ck);
                clk_disable(mcbsp_api_ck);

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]