From: Tony Lindgren <tony@atomide.com>
To: Dirk Behme <dirk.behme@googlemail.com>
Cc: OMAP <Linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH] ARM: OMAP: Make OMAP1 work again
Date: Fri, 6 Oct 2006 15:49:00 +0300 [thread overview]
Message-ID: <20061006124859.GJ32423@atomide.com> (raw)
In-Reply-To: <452628C9.1020603@gmail.com>
* Dirk Behme <dirk.behme@googlemail.com> [061006 12:58]:
>
> In mach-omap1/mailbox.c the mailbox name is .name = "DSP"
> while in plat-omap/dsp/dsp_core.c function dsp_mbox_init()
> asks for "dsp". This results in a strcmp() mismatch and then
> OMAP1 system crashes due to NULL pointer. OMAP2 is correct,
> there .name is "dsp". Correct OMAP1 name to "dsp" as well.
>
> Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>
>
> --- ./arch/arm/mach-omap1/mailbox.c_orig 2006-10-06 11:08:50.000000000 +0200
> +++ ./arch/arm/mach-omap1/mailbox.c 2006-10-06 11:09:13.000000000 +0200
> @@ -136,7 +136,7 @@ static struct omap_mbox1_priv omap1_mbox
> };
>
> struct omap_mbox mbox_dsp_info = {
> - .name = "DSP",
> + .name = "dsp",
> .ops = &omap1_mbox_ops,
> .priv = &omap1_mbox_dsp_priv,
> };
>
>
Great, I pushed it.
Regards,
Tony
prev parent reply other threads:[~2006-10-06 12:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 9:58 [PATCH] ARM: OMAP: Make OMAP1 work again Dirk Behme
2006-10-06 10:21 ` Bug? - OSK Frame Buffer Support in Kernel 2.6.18-omap1 Sideleau, Scott R
2006-10-06 10:43 ` Dirk Behme
2006-10-06 16:13 ` Sideleau, Scott R
2006-10-06 19:05 ` Can't Boot " Sideleau, Scott R
2006-10-06 19:30 ` Dirk Behme
2006-10-06 12:49 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061006124859.GJ32423@atomide.com \
--to=tony@atomide.com \
--cc=Linux-omap-open-source@linux.omap.com \
--cc=dirk.behme@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox