From: Tony Lindgren <tony@atomide.com>
To: balrogg@gmail.com
Cc: Linux-OMAP <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH] Request OMAP MMC Write-protect pin
Date: Wed, 18 Oct 2006 22:12:50 +0300 [thread overview]
Message-ID: <20061018191249.GB4669@atomide.com> (raw)
In-Reply-To: <fb249edb0609221310y33ac7b4dse744a587d5b9d2bb@mail.gmail.com>
Hi,
* andrzej zaborowski <balrog@zabor.org> [060922 23:17]:
> [Sorry, forgot about the actual diff]
>
> Adds code that requests and frees the WP GPIO pin in OMAP MMC host
> driver, similarly to how the MMC Power and MMC Cover-switch GPIOs are
> treated.
>
> Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
>
> diff --git a/drivers/mmc/omap.c b/drivers/mmc/omap.c
> index ae08a37..a01682b 100644
> --- a/drivers/mmc/omap.c
> +++ b/drivers/mmc/omap.c
> @@ -1009,7 +1009,7 @@ static int mmc_omap_get_ro(struct mmc_ho
> {
> struct mmc_omap_host *host = mmc_priv(mmc);
>
> - return host->wp_pin && omap_get_gpio_datain(host->wp_pin);
> + return (host->wp_pin >= 0) && omap_get_gpio_datain(host->wp_pin);
> }
...
This all looks OK, but let's wait on this as I believe there are
some patches coming to deal with it in board-*.c files.
Regards,
Tony
prev parent reply other threads:[~2006-10-18 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-22 20:08 [PATCH] Request OMAP MMC Write-protect pin andrzej zaborowski
2006-09-22 20:10 ` andrzej zaborowski
2006-10-18 19:12 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061018191249.GB4669@atomide.com \
--to=tony@atomide.com \
--cc=balrogg@gmail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox