public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: David Cohen <david.cohen@indt.org.br>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] McBSP dependence for DSP on ARCH_OMAP1 is missing
Date: Mon, 23 Oct 2006 16:18:25 +0300	[thread overview]
Message-ID: <20061023131824.GD22577@atomide.com> (raw)
In-Reply-To: <453931C6.9080209@indt.org.br>

* David Cohen <david.cohen@indt.org.br> [061020 23:34]:
> Hi,
> 
> I've tried to compile an up-to-dated kernel tree configured for h3. I
> got some errors due to the McBSP depends on OMAP_DSP if ARCH_OMAP1 is
> set, as we can see at these lines from "arch/arm/plat-omap/mcbsp.c":
> 
> (...)
> #ifdef CONFIG_ARCH_OMAP1
> static void omap_mcbsp_dsp_request(void)
> {
>     if (cpu_is_omap15xx() || cpu_is_omap16xx()) {
>         omap_dsp_request_mem();
> 
> (...)
> #endif
> (...)
> 
> So, I've made this minimal patch to deal with this problem. It worked
> well for me. But I put, also, CONFIG_OMAP_DSP=y as default on h3 config
> file to keep the OMAP_MCBSP as default too.

This should be already fixed in a recent patch:

http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commitdiff;h=40749d1d5792748372ae3becf638944b896ef8f1

Regards,

Tony

      reply	other threads:[~2006-10-23 13:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-20 20:29 [PATCH] McBSP dependence for DSP on ARCH_OMAP1 is missing David Cohen
2006-10-23 13:18 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061023131824.GD22577@atomide.com \
    --to=tony@atomide.com \
    --cc=david.cohen@indt.org.br \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox