* [PATCH 1/4] PalmZ71 - OMAP310 Clocks
@ 2006-10-24 15:19 Marek Vašut
2006-10-25 18:07 ` Tony Lindgren
2006-10-25 23:54 ` Marek Vašut
0 siblings, 2 replies; 8+ messages in thread
From: Marek Vašut @ 2006-10-24 15:19 UTC (permalink / raw)
To: linux-omap-open-source
[-- Attachment #1: Type: text/plain, Size: 46 bytes --]
Hi,
this patch enables some clock on omap310.
[-- Attachment #2: clock-omap310.patch --]
[-- Type: text/x-diff, Size: 2407 bytes --]
diff -Naur linux-omap/arch/arm/mach-omap1/clock.h linux-omap-z71/arch/arm/mach-omap1/clock.h
--- linux-omap/arch/arm/mach-omap1/clock.h 2006-10-15 16:09:10.000000000 +0200
+++ linux-omap-z71/arch/arm/mach-omap1/clock.h 2006-10-20 21:56:49.000000000 +0200
@@ -282,7 +282,7 @@
static struct clk dsp_ck = {
.name = "dsp_ck",
.parent = &ck_dpll1,
- .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
+ .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
RATE_CKCTL,
.enable_reg = (void __iomem *)ARM_CKCTL,
.enable_bit = EN_DSPCK,
@@ -295,7 +295,7 @@
static struct clk dspmmu_ck = {
.name = "dspmmu_ck",
.parent = &ck_dpll1,
- .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
+ .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
RATE_CKCTL | ALWAYS_ENABLED,
.rate_offset = CKCTL_DSPMMUDIV_OFFSET,
.recalc = &omap1_ckctl_recalc,
@@ -306,7 +306,7 @@
static struct clk dspper_ck = {
.name = "dspper_ck",
.parent = &ck_dpll1,
- .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
+ .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
RATE_CKCTL | VIRTUAL_IO_ADDRESS,
.enable_reg = (void __iomem *)DSP_IDLECT2,
.enable_bit = EN_PERCK,
@@ -320,7 +320,7 @@
static struct clk dspxor_ck = {
.name = "dspxor_ck",
.parent = &ck_ref,
- .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
+ .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
VIRTUAL_IO_ADDRESS,
.enable_reg = (void __iomem *)DSP_IDLECT2,
.enable_bit = EN_XORPCK,
@@ -332,7 +332,7 @@
static struct clk dsptim_ck = {
.name = "dsptim_ck",
.parent = &ck_ref,
- .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
+ .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
VIRTUAL_IO_ADDRESS,
.enable_reg = (void __iomem *)DSP_IDLECT2,
.enable_bit = EN_DSPTIMCK,
@@ -374,7 +374,7 @@
static struct clk tipb_ck = {
/* No-idle controlled by "tc_ck" */
- .name = "tibp_ck",
+ .name = "tipb_ck",
.parent = &tc_ck.clk,
.flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP310 |
ALWAYS_ENABLED,
@@ -733,7 +733,7 @@
static struct clk i2c_fck = {
.name = "i2c_fck",
.id = 1,
- .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
+ .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
VIRTUAL_CLOCK | CLOCK_NO_IDLE_PARENT |
ALWAYS_ENABLED,
.parent = &armxor_ck.clk,
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/4] PalmZ71 - OMAP310 Clocks
2006-10-24 15:19 [PATCH 1/4] PalmZ71 - OMAP310 Clocks Marek Vašut
@ 2006-10-25 18:07 ` Tony Lindgren
2006-10-25 20:17 ` andrzej zaborowski
2006-10-25 23:54 ` Marek Vašut
1 sibling, 1 reply; 8+ messages in thread
From: Tony Lindgren @ 2006-10-25 18:07 UTC (permalink / raw)
To: Marek Vašut; +Cc: linux-omap-open-source
* Marek Vašut <marek.vasut@gmail.com> [061024 18:22]:
> Hi,
> this patch enables some clock on omap310.
> diff -Naur linux-omap/arch/arm/mach-omap1/clock.h linux-omap-z71/arch/arm/mach-omap1/clock.h
> --- linux-omap/arch/arm/mach-omap1/clock.h 2006-10-15 16:09:10.000000000 +0200
> +++ linux-omap-z71/arch/arm/mach-omap1/clock.h 2006-10-20 21:56:49.000000000 +0200
> @@ -282,7 +282,7 @@
> static struct clk dsp_ck = {
> .name = "dsp_ck",
> .parent = &ck_dpll1,
> - .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> + .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> RATE_CKCTL,
> .enable_reg = (void __iomem *)ARM_CKCTL,
> .enable_bit = EN_DSPCK,
> @@ -295,7 +295,7 @@
> static struct clk dspmmu_ck = {
> .name = "dspmmu_ck",
> .parent = &ck_dpll1,
> - .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> + .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> RATE_CKCTL | ALWAYS_ENABLED,
> .rate_offset = CKCTL_DSPMMUDIV_OFFSET,
> .recalc = &omap1_ckctl_recalc,
> @@ -306,7 +306,7 @@
> static struct clk dspper_ck = {
> .name = "dspper_ck",
> .parent = &ck_dpll1,
> - .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> + .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> RATE_CKCTL | VIRTUAL_IO_ADDRESS,
> .enable_reg = (void __iomem *)DSP_IDLECT2,
> .enable_bit = EN_PERCK,
> @@ -320,7 +320,7 @@
> static struct clk dspxor_ck = {
> .name = "dspxor_ck",
> .parent = &ck_ref,
> - .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> + .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> VIRTUAL_IO_ADDRESS,
> .enable_reg = (void __iomem *)DSP_IDLECT2,
> .enable_bit = EN_XORPCK,
> @@ -332,7 +332,7 @@
> static struct clk dsptim_ck = {
> .name = "dsptim_ck",
> .parent = &ck_ref,
> - .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> + .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> VIRTUAL_IO_ADDRESS,
> .enable_reg = (void __iomem *)DSP_IDLECT2,
> .enable_bit = EN_DSPTIMCK,
> @@ -374,7 +374,7 @@
>
> static struct clk tipb_ck = {
> /* No-idle controlled by "tc_ck" */
> - .name = "tibp_ck",
> + .name = "tipb_ck",
> .parent = &tc_ck.clk,
> .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP310 |
> ALWAYS_ENABLED,
> @@ -733,7 +733,7 @@
> static struct clk i2c_fck = {
> .name = "i2c_fck",
> .id = 1,
> - .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> + .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> VIRTUAL_CLOCK | CLOCK_NO_IDLE_PARENT |
> ALWAYS_ENABLED,
> .parent = &armxor_ck.clk,
Hmm, I thought 310 did not have a DSP? Or is it only 710 that does not
have a DSP?
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 1/4] PalmZ71 - OMAP310 Clocks
@ 2006-10-25 19:38 Woodruff, Richard
2006-10-25 20:08 ` Tony Lindgren
0 siblings, 1 reply; 8+ messages in thread
From: Woodruff, Richard @ 2006-10-25 19:38 UTC (permalink / raw)
To: Tony Lindgren, Marek Vašut; +Cc: linux-omap-open-source
A real OMAP310 does not have a DSP. Some early 1510s may have been sold as 310s.
Regards,
Richard W.
> -----Original Message-----
> From: linux-omap-open-source-bounces@linux.omap.com [mailto:linux-omap-
> open-source-bounces@linux.omap.com] On Behalf Of Tony Lindgren
> Sent: Wednesday, October 25, 2006 1:08 PM
> To: Marek Vašut
> Cc: linux-omap-open-source@linux.omap.com
> Subject: Re: [PATCH 1/4] PalmZ71 - OMAP310 Clocks
>
> * Marek Vašut <marek.vasut@gmail.com> [061024 18:22]:
> > Hi,
> > this patch enables some clock on omap310.
>
> > diff -Naur linux-omap/arch/arm/mach-omap1/clock.h linux-omap-
> z71/arch/arm/mach-omap1/clock.h
> > --- linux-omap/arch/arm/mach-omap1/clock.h 2006-10-15
> 16:09:10.000000000 +0200
> > +++ linux-omap-z71/arch/arm/mach-omap1/clock.h 2006-10-20
> 21:56:49.000000000 +0200
> > @@ -282,7 +282,7 @@
> > static struct clk dsp_ck = {
> > .name = "dsp_ck",
> > .parent = &ck_dpll1,
> > - .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> > + .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 |
> CLOCK_IN_OMAP16XX |
> > RATE_CKCTL,
> > .enable_reg = (void __iomem *)ARM_CKCTL,
> > .enable_bit = EN_DSPCK,
> > @@ -295,7 +295,7 @@
> > static struct clk dspmmu_ck = {
> > .name = "dspmmu_ck",
> > .parent = &ck_dpll1,
> > - .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> > + .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 |
> CLOCK_IN_OMAP16XX |
> > RATE_CKCTL | ALWAYS_ENABLED,
> > .rate_offset = CKCTL_DSPMMUDIV_OFFSET,
> > .recalc = &omap1_ckctl_recalc,
> > @@ -306,7 +306,7 @@
> > static struct clk dspper_ck = {
> > .name = "dspper_ck",
> > .parent = &ck_dpll1,
> > - .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> > + .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 |
> CLOCK_IN_OMAP16XX |
> > RATE_CKCTL | VIRTUAL_IO_ADDRESS,
> > .enable_reg = (void __iomem *)DSP_IDLECT2,
> > .enable_bit = EN_PERCK,
> > @@ -320,7 +320,7 @@
> > static struct clk dspxor_ck = {
> > .name = "dspxor_ck",
> > .parent = &ck_ref,
> > - .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> > + .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 |
> CLOCK_IN_OMAP16XX |
> > VIRTUAL_IO_ADDRESS,
> > .enable_reg = (void __iomem *)DSP_IDLECT2,
> > .enable_bit = EN_XORPCK,
> > @@ -332,7 +332,7 @@
> > static struct clk dsptim_ck = {
> > .name = "dsptim_ck",
> > .parent = &ck_ref,
> > - .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> > + .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 |
> CLOCK_IN_OMAP16XX |
> > VIRTUAL_IO_ADDRESS,
> > .enable_reg = (void __iomem *)DSP_IDLECT2,
> > .enable_bit = EN_DSPTIMCK,
> > @@ -374,7 +374,7 @@
> >
> > static struct clk tipb_ck = {
> > /* No-idle controlled by "tc_ck" */
> > - .name = "tibp_ck",
> > + .name = "tipb_ck",
> > .parent = &tc_ck.clk,
> > .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP310 |
> > ALWAYS_ENABLED,
> > @@ -733,7 +733,7 @@
> > static struct clk i2c_fck = {
> > .name = "i2c_fck",
> > .id = 1,
> > - .flags = CLOCK_IN_OMAP1510 | CLOCK_IN_OMAP16XX |
> > + .flags = CLOCK_IN_OMAP310 | CLOCK_IN_OMAP1510 |
> CLOCK_IN_OMAP16XX |
> > VIRTUAL_CLOCK | CLOCK_NO_IDLE_PARENT |
> > ALWAYS_ENABLED,
> > .parent = &armxor_ck.clk,
>
> Hmm, I thought 310 did not have a DSP? Or is it only 710 that does not
> have a DSP?
>
> Tony
> _______________________________________________
> Linux-omap-open-source mailing list
> Linux-omap-open-source@linux.omap.com
> http://linux.omap.com/mailman/listinfo/linux-omap-open-source
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/4] PalmZ71 - OMAP310 Clocks
2006-10-25 19:38 Woodruff, Richard
@ 2006-10-25 20:08 ` Tony Lindgren
0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2006-10-25 20:08 UTC (permalink / raw)
To: Woodruff, Richard; +Cc: linux-omap-open-source
* Woodruff, Richard <r-woodruff2@ti.com> [061025 22:39]:
> A real OMAP310 does not have a DSP. Some early 1510s may have been sold as 310s.
Thanks for the confirmation. Marek, can you check what your omap IDs
are? See arm/mach-omap1/id.c.
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/4] PalmZ71 - OMAP310 Clocks
2006-10-25 18:07 ` Tony Lindgren
@ 2006-10-25 20:17 ` andrzej zaborowski
2006-10-25 23:45 ` Marek Vašut
0 siblings, 1 reply; 8+ messages in thread
From: andrzej zaborowski @ 2006-10-25 20:17 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap-open-source
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
Hi,
On 25/10/06, Tony Lindgren <tony@atomide.com> wrote:
> * Marek Vašut <marek.vasut@gmail.com> [061024 18:22]:
> > Hi,
> > this patch enables some clock on omap310.
>
...
>
> Hmm, I thought 310 did not have a DSP? Or is it only 710 that does not
> have a DSP?
I think the issue here is that some of McBSPs depend on the DSP clocks
(or rather on the corresponding bits being set in "clock & reset"
module). I don't know if this is a hardware dependency or Linux clock
framework dependency, but I wouldn't be surprised if it's hardware.
--
balrog 2oo6
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/4] PalmZ71 - OMAP310 Clocks
2006-10-25 20:17 ` andrzej zaborowski
@ 2006-10-25 23:45 ` Marek Vašut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vašut @ 2006-10-25 23:45 UTC (permalink / raw)
To: balrogg, linux-omap-open-source, tony
Dne středa 25 říjen 2006 22:17 andrzej zaborowski napsal(a):
> Hi,
>
> On 25/10/06, Tony Lindgren <tony@atomide.com> wrote:
> > * Marek Vašut <marek.vasut@gmail.com> [061024 18:22]:
> > > Hi,
> > > this patch enables some clock on omap310.
>
> ...
>
> > Hmm, I thought 310 did not have a DSP? Or is it only 710 that does not
> > have a DSP?
>
> I think the issue here is that some of McBSPs depend on the DSP clocks
> (or rather on the corresponding bits being set in "clock & reset"
> module). I don't know if this is a hardware dependency or Linux clock
> framework dependency, but I wouldn't be surprised if it's hardware.
Yup, that´s right. Without these changes the soundchip (aic23) wont work (it´s
connected over mcbsp). It´s MCBSP dependency as balrog said.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/4] PalmZ71 - OMAP310 Clocks
2006-10-24 15:19 [PATCH 1/4] PalmZ71 - OMAP310 Clocks Marek Vašut
2006-10-25 18:07 ` Tony Lindgren
@ 2006-10-25 23:54 ` Marek Vašut
2006-10-26 21:22 ` Tony Lindgren
1 sibling, 1 reply; 8+ messages in thread
From: Marek Vašut @ 2006-10-25 23:54 UTC (permalink / raw)
To: linux-omap-open-source
Dne úterý 24 říjen 2006 17:19 jste napsal(a):
> Hi,
> this patch enables some clock on omap310.
Signed-off-by: Marek Vašut <marek.vasut@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/4] PalmZ71 - OMAP310 Clocks
2006-10-25 23:54 ` Marek Vašut
@ 2006-10-26 21:22 ` Tony Lindgren
0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2006-10-26 21:22 UTC (permalink / raw)
To: Marek Vašut; +Cc: linux-omap-open-source
* Marek Vašut <marek.vasut@gmail.com> [061026 02:55]:
> Dne úterý 24 říjen 2006 17:19 jste napsal(a):
> > Hi,
> > this patch enables some clock on omap310.
> Signed-off-by: Marek Vašut <marek.vasut@gmail.com>
Pushing today.
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2006-10-26 21:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-24 15:19 [PATCH 1/4] PalmZ71 - OMAP310 Clocks Marek Vašut
2006-10-25 18:07 ` Tony Lindgren
2006-10-25 20:17 ` andrzej zaborowski
2006-10-25 23:45 ` Marek Vašut
2006-10-25 23:54 ` Marek Vašut
2006-10-26 21:22 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2006-10-25 19:38 Woodruff, Richard
2006-10-25 20:08 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox