public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan McDowell <noodles@earth.li>
To: linux-omap-open-source@linux.omap.com
Subject: [PATCH] ARM: OMAP: Fix Amstrad Delta omap-keypad usage.
Date: Fri, 27 Oct 2006 17:49:41 +0100	[thread overview]
Message-ID: <20061027164941.GQ13361@earth.li> (raw)
In-Reply-To: <20061027161659.GP13361@earth.li>

On Fri, Oct 27, 2006 at 05:16:59PM +0100, Jonathan McDowell wrote:
> However having prodded further I'm seeing incorrect key parsing with
> the omap-keypad driver under both -rc2 and -rc3 (works fine in
> 2.6.18-omap1). Numerous keys now returns strings of characters rather
> than the single expected character. A few keys still work as expected
> however. Before I dig in further is anyone else seeing anything similar?

This appears to be due to the addition of keymapsize to the
omap_kp_platform_data structure. The patch below fixes things up for
the Delta; other boards appear to have already had this done.

Signed-Off-By: Jonathan McDowell <noodles@earth.li>

-----
diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
index 0a0c06f..c73ca61 100644
--- a/arch/arm/mach-omap1/board-ams-delta.c
+++ b/arch/arm/mach-omap1/board-ams-delta.c
@@ -187,10 +187,11 @@ static struct resource ams_delta_kp_reso
 };
 
 static struct omap_kp_platform_data ams_delta_kp_data = {
-	.rows	= 8,
-	.cols	= 8,
-	.keymap = ams_delta_keymap,
-	.rep	= 1,
+	.rows		= 8,
+	.cols		= 8,
+	.keymap 	= ams_delta_keymap,
+	.keymapsize	= ARRAY_SIZE(ams_delta_keymap),
+	.delay		= 9,
 };
 
 static struct platform_device ams_delta_kp_device = {
-----

J.

-- 
   101 things you can't have too   |  .''`.  Debian GNU/Linux Developer
  much of : 9 - Processing power.  | : :' :  Happy to accept PGP signed
                                   | `. `'   or encrypted mail - RSA +
                                   |   `-    DSA keys on the keyservers.

  reply	other threads:[~2006-10-27 16:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-23 20:39 Git tree updated to 2.6.19-rc2 Tony Lindgren
2006-10-24  7:53 ` Komal Shah
2006-10-28  6:31   ` Aic23 NULL pointer exception, was: " Dirk Behme
2006-10-24 11:05 ` [PATCH] ARM: OMAP: Fixup omap-rtc (was: Git tree updated to 2.6.19-rc2) Jonathan McDowell
2006-10-24 17:57   ` David Brownell
2006-10-27 12:45     ` tony
2006-10-27 16:16   ` omap-keypad issues with 2.6.19-rc? Jonathan McDowell
2006-10-27 16:49     ` Jonathan McDowell [this message]
2006-10-24 16:16 ` Git tree updated to 2.6.19-rc2 Dirk Behme
2006-10-27 12:50   ` tony
2006-10-27 15:30     ` Dirk Behme
2006-10-29 22:09     ` Hiroshi DOYU
2006-10-26 20:22 ` David Brownell
2006-10-27 12:53   ` tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061027164941.GQ13361@earth.li \
    --to=noodles@earth.li \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox