public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: linux-omap-open-source@linux.omap.com
Cc: Andrew Morton <akpm@osdl.org>,
	linux-usb-devel@lists.sourceforge.net,
	"Arnaud Patard (Rtp)" <arnaud.patard@rtp-net.org>,
	Greg KH <greg@kroah.com>
Subject: Re: Invalid Storage Class BUG
Date: Wed, 1 Nov 2006 14:26:26 -0800	[thread overview]
Message-ID: <200611011426.28869.david-b@pacbell.net> (raw)
In-Reply-To: <85ejsmn99r.fsf@orfeo.duckcorp.org>

That's identical to what I've been using in some work on a high-speed
OTG controller that I suspect Felipe is getting familiar with ... :)

So here's a standard format patch.  This should get into 2.6.19 IMO.

(Andrew, ISTR that a topological sort won't work in this file.)

=================	CUT HERE

Remove complaint from newer GCCs; they don't like forward function
declarations except in top-level contexts.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Index: h4/drivers/usb/core/hub.c
===================================================================
--- h4.orig/drivers/usb/core/hub.c	2006-10-25 13:37:45.000000000 -0700
+++ h4/drivers/usb/core/hub.c	2006-10-25 21:54:17.000000000 -0700
@@ -1188,6 +1188,7 @@ static inline void show_string(struct us
 
 #ifdef	CONFIG_USB_OTG
 #include "otg_whitelist.h"
+static int __usb_port_suspend(struct usb_device *, int port1);
 #endif
 
 /**
@@ -1289,8 +1290,6 @@ int usb_new_device(struct usb_device *ud
 		 * (Includes HNP test device.)
 		 */
 		if (udev->bus->b_hnp_enable || udev->bus->is_b_host) {
-			static int __usb_port_suspend(struct usb_device *,
-						int port1);
 			err = __usb_port_suspend(udev, udev->bus->otg_port);
 			if (err < 0)
 				dev_dbg(&udev->dev, "HNP fail, %d\n", err);

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

  reply	other threads:[~2006-11-01 22:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-01 20:50 Invalid Storage Class BUG Felipe Balbi
2006-11-01 21:14 ` Alan Stern
2006-11-01 21:58   ` Andrew Morton
2006-11-01 21:32 ` Arnaud Patard
2006-11-01 22:26   ` David Brownell [this message]
2006-11-01 22:41     ` Andrew Morton
2006-11-01 22:48       ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611011426.28869.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=akpm@osdl.org \
    --cc=arnaud.patard@rtp-net.org \
    --cc=greg@kroah.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox