Re: Invalid Storage Class BUG

David Brownell
2006-11-01T22:26:26Z

That's identical to what I've been using in some work on a high-speed
OTG controller that I suspect Felipe is getting familiar with ... :)

So here's a standard format patch. This should get into 2.6.19 IMO.

(Andrew, ISTR that a topological sort won't work in this file.)

================= CUT HERE

Remove complaint from newer GCCs; they don't like forward function
declarations except in top-level contexts.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Index: h4/drivers/usb/core/hub.c
===================================================================
--- h4.orig/drivers/usb/core/hub.c 2006-10-25 13:37:45.000000000 -0700
+++ h4/drivers/usb/core/hub.c 2006-10-25 21:54:17.000000000 -0700
@@ -1188,6 +1188,7 @@ static inline void show_string(struct us

#ifdef CONFIG_USB_OTG
#include "otg_whitelist.h"
+static int __usb_port_suspend(struct usb_device *, int port1);
#endif

/**
@@ -1289,8 +1290,6 @@ int usb_new_device(struct usb_device *ud
* (Includes HNP test device.)
*/
if (udev->bus->b_hnp_enable || udev->bus->is_b_host) {
- static int __usb_port_suspend(struct usb_device *,
- int port1);
err = __usb_port_suspend(udev, udev->bus->otg_port);
if (err < 0)
dev_dbg(&udev->dev, "HNP fail, %d\n", err);