Re: PalmTT

Tony Lindgren
2006-11-10T00:16:43Z

Hi,

* Marek Vašut <marek.vasut@gmail.com> [061107 23:15]:
> Hi,
> I´ve pulled latest git snapshot and it seems palmtt is there (all four
> patches - board, defconfig, lcd, leds), but as Tony wrote I had to fix those
> tabs (formating) before it´ll be (maybe ;-)) merged. I havent seen any
> mention about merging TT on gitweb so I was just curious why is it there :)

Oops, sorry. Looks like I pushed them accidentally in Kyungmin's USB
patch.

> Well ... doesnt matter ... here´s a patch that fixes formating in
> board-palmtt.c and lcd-palmtt.c (formating - tabs and removing commented
> code). I´ve also made a small change to board-palmz71.c formating.

Well I just reverted the patch, and reapplied Kyungmin's patch without
your code :)

The reason is that we want to be able to send the patches upstream as
they are without editing them again. And reverting a patch and reapplying
the modified patch makes sending patches upstream easy, as we can just
ignore the reverted patches.

Can you please repost your series one more time with the formatting
changes?

> Plus I changed GPIO 6 name in board-palmz71(tt).h (renamed
> PALMxxx_PINTDAV_GPIO to PALMxxx_PENIRQ_GPIO, where xxx=TT or Z71). Hope it
> doesnt matter I put it into one patch while it´s a small (one line - see the
> bottom of the patch) change.

OK

Regards,

Tony