From: Tony Lindgren <tony@atomide.com>
To: "Syed Mohammed, Khasim" <x0khasim@ti.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] To add OMAP 2430 Support
Date: Thu, 9 Nov 2006 04:23:14 +0200 [thread overview]
Message-ID: <20061109022314.GD9740@atomide.com> (raw)
In-Reply-To: <77C7F7CB1230A74A9D19C0C111E6EDBE01CADC92@DLEE09.ent.ti.com>
* Syed Mohammed, Khasim <x0khasim@ti.com> [061104 00:56]:
> Dirk / David,
>
> Many Thanks for the review.
>
> Actually we can operate SMC91x in both edge and level. On H4 Ethernet
> does work with IRQF_TRIGGER_LOW, I didn't want to break any existing
> functionality on first try :).
>
> Dirk, thanks for pointing the comment to me, due to my screen color I
> missed it :). For now I can make both H4 and 2430SDP as
> IRQF_TRIGGER_FALLING.
>
> But if we agree, I can configure H4 and 2430SDP for IRQF_TRIGGER_LOW.
Yeah, let's change it. Another thing that should be done for smc91x
on 24xx is to use the gpmc code for timings.
Regards,
Tony
next prev parent reply other threads:[~2006-11-09 2:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-03 18:44 [PATCH] To add OMAP 2430 Support Syed Mohammed, Khasim
2006-11-03 19:03 ` Dirk Behme
2006-11-03 19:28 ` Dirk Behme
2006-11-03 22:00 ` David Brownell
2006-11-03 22:49 ` Syed Mohammed, Khasim
2006-11-09 2:23 ` Tony Lindgren [this message]
2006-11-09 2:22 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2006-11-09 15:01 Woodruff, Richard
2006-11-10 0:46 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061109022314.GD9740@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=x0khasim@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox