From: Tony Lindgren <tony@atomide.com>
To: Dirk Behme <dirk.behme@googlemail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: Fix warning in mach-omap1
Date: Fri, 10 Nov 2006 01:24:19 +0200 [thread overview]
Message-ID: <20061109232419.GJ16172@atomide.com> (raw)
In-Reply-To: <454CB67B.70706@gmail.com>
* Dirk Behme <dirk.behme@googlemail.com> [061104 17:56]:
> Fix warning
>
> arch/arm/mach-omap1/pm.c: In function 'omap_pm_init':
> arch/arm/mach-omap1/pm.c:765: warning: ignoring return value
> of 'subsys_create_file', declared with attribute
> warn_unused_result
>
> Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>
>
> Index: linux-osk/arch/arm/mach-omap1/pm.c
> ===================================================================
> --- linux-osk.orig/arch/arm/mach-omap1/pm.c
> +++ linux-osk/arch/arm/mach-omap1/pm.c
> @@ -706,6 +706,8 @@ static struct pm_ops omap_pm_ops ={
>
> static int __init omap_pm_init(void)
> {
> + int error;
> +
> printk("Power Management for TI OMAP.\n");
>
> /*
> @@ -762,7 +764,9 @@ static int __init omap_pm_init(void)
> omap_pm_init_proc();
> #endif
>
> - subsys_create_file(&power_subsys, &sleep_while_idle_attr);
> + error = subsys_create_file(&power_subsys, &sleep_while_idle_attr);
> + if(error)
> + printk(KERN_ERR "subsys_create_file failed: %d\n", error);
>
> if (cpu_is_omap16xx()) {
> /* configure LOW_PWR pin */
>
Pushing today.
Tony
next prev parent reply other threads:[~2006-11-09 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-04 15:49 [PATCH] ARM: OMAP: Fix warning in mach-omap1 Dirk Behme
2006-11-09 23:24 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-10-27 16:19 Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061109232419.GJ16172@atomide.com \
--to=tony@atomide.com \
--cc=dirk.behme@googlemail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox