From: Tony Lindgren <tony@atomide.com>
To: balrogg@gmail.com
Cc: Linux-OMAP <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH, RFC] ARM: OMAP: Convert gpio-switch to platform_driver
Date: Fri, 10 Nov 2006 01:29:57 +0200 [thread overview]
Message-ID: <20061109232957.GM16172@atomide.com> (raw)
In-Reply-To: <fb249edb0611051733x6fe980d4r7384d37f79797645@mail.gmail.com>
* andrzej zaborowski <balrog@zabor.org> [061106 03:42]:
> [I'm not very sure about this, but shouldn't the driver be a platform
> driver if its parent bus is the platform bus? It's especially annoying
> on resuming from sleep because the driver structure is passed to
> platform_resume_early() where it is casted to struct platform_device
> and .resume_early returns a bogus value. The kernel Oops'es but since
> the LCD is not yet resumed the device looks like dead and it's hard to
> track down.]
>
> Converts the gpio-switch driver to platform_driver to avoid bad cast
> which occurs because the bus type is set to platform bus. Also
> silences the following warnings:
>
> arch/arm/plat-omap/gpio-switch.c:292: warning: ignoring return value
> of 'device_create_file', declared with attribute warn_unused_result
> arch/arm/plat-omap/gpio-switch.c:293: warning: ignoring return value
> of 'device_create_file', declared with attribute warn_unused_result
> arch/arm/plat-omap/gpio-switch.c:294: warning: ignoring return value
> of 'device_create_file', declared with attribute warn_unused_result
Sounds like this code had missed the platform device conversion earlier.
Pushing today.
Tony
prev parent reply other threads:[~2006-11-09 23:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 1:33 [PATCH, RFC] ARM: OMAP: Convert gpio-switch to platform_driver andrzej zaborowski
2006-11-09 23:29 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061109232957.GM16172@atomide.com \
--to=tony@atomide.com \
--cc=balrogg@gmail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox