From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] Fix ADS7846 dependencies Date: Sat, 11 Nov 2006 02:37:40 +0200 Message-ID: <20061111003740.GS26185@atomide.com> References: <85psbv77ox.fsf@orfeo.duckcorp.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <85psbv77ox.fsf@orfeo.duckcorp.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Arnaud Patard , David Brownell Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org Hi, * Arnaud Patard [061110 15:34]: > Hi, > > While playing with my kernel configuration, I found out that now, > setting CONFIG_HWMON to 'n' and TOUCHSCREEN_ADS7846 to 'y' was allowed, > which leads to a build failure. > This was caused by the commit 954423251daf362272076c6228dcdac65d72b287 > which reverts the changes introduced by the commit > 659cb49d6a8ba8d5651e53dd22a0addab6a479e6. > This patch fix the trouble. > > Signed-off-by: Arnaud Patard > --- > --- > drivers/input/touchscreen/Kconfig | 5 4 + 1 - 0 ! > 1 files changed, 4 insertions(+), 1 deletion(-) > > Index: linux-2.6.18/drivers/input/touchscreen/Kconfig > =================================================================== > --- linux-2.6.18.orig/drivers/input/touchscreen/Kconfig 2006-09-20 05:42:06.000000000 +0200 > +++ linux-2.6.18/drivers/input/touchscreen/Kconfig 2006-11-10 14:24:47.000000000 +0100 > @@ -14,10 +14,13 @@ if INPUT_TOUCHSCREEN > config TOUCHSCREEN_ADS7846 > tristate "ADS 7846 based touchscreens" > depends on SPI_MASTER > + select HWMON > help > Say Y here if you have a touchscreen interface using the > ADS7846 controller, and your board-specific initialization > - code includes that in its table of SPI devices. > + code includes that in its table of SPI devices. You will > + also get hwmon interfaces for the temperature and voltage > + sensors this chip provides. > > If unsure, say N (but it's safe to say "Y"). > This looks OK to me, Dave any comments? Tony