[PATCH] ARM: OMAP: OMAP310 i2c fix

[PATCH] ARM: OMAP: OMAP310 i2c fix

[Marek Vašut]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

Hi,

when I turned on i2c on my omap310 based palmz71 and booted the kernel, it 
hanged. I´ve tracked the place where it hangs and fixed it. Here´s the small 
patch.

[-- Attachment #2: omap310-i2c-no-hang.patch --]
[-- Type: text/x-diff, Size: 528 bytes --]

diff -Naur linux-omap-current/arch/arm/plat-omap/dsp/dsp_common.c linux-omap/arch/arm/plat-omap/dsp/dsp_common.c
--- linux-omap-current/arch/arm/plat-omap/dsp/dsp_common.c	2006-11-12 11:24:41.000000000 +0100
+++ linux-omap/arch/arm/plat-omap/dsp/dsp_common.c	2006-11-12 12:30:55.000000000 +0100
@@ -273,7 +273,7 @@
 
 	dspmem_size = 0;
 #ifdef CONFIG_ARCH_OMAP15XX
-	if (cpu_is_omap1510()) {
+	if (cpu_is_omap15xx()) {
 		dspmem_base = OMAP1510_DSP_BASE;
 		dspmem_size = OMAP1510_DSP_SIZE;
 		daram_base = OMAP1510_DARAM_BASE;

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ARM: OMAP: OMAP310 i2c fix

[Marek Vašut]

Dne neděle 12 listopad 2006 19:30 jste napsal(a):
> Hi,
>
> when I turned on i2c on my omap310 based palmz71 and booted the kernel, it
> hanged. I´ve tracked the place where it hangs and fixed it. Here´s the
> small patch.
forgot to add this ;-)

Signed-off-by: Marek Vašut <marek.vasut@gmail.com>

Re: [PATCH] ARM: OMAP: OMAP310 i2c fix

[Trilok Soni]

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

On 11/12/06, Marek Vašut <marek.vasut@gmail.com> wrote:
> Dne neděle 12 listopad 2006 19:30 jste napsal(a):
> > Hi,
> >
> > when I turned on i2c on my omap310 based palmz71 and booted the kernel, it
> > hanged. I´ve tracked the place where it hangs and fixed it. Here´s the
> > small patch.
> forgot to add this ;-)
>
> Signed-off-by: Marek Vašut <marek.vasut@gmail.com>

Just to confirm your patch comment. Did you enabled OMAP_DSP or I2C?
as you had modified dsp_common.c. Going the generic way, dsp_common.c
should pick up memory addresses from arch- specific files, but as
omap_dsp_init is called in arch_init, I don't know, what would be the
cleaner way to do it.

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ARM: OMAP: OMAP310 i2c fix

[Marek Vašut]

Dne pondělí 13 listopad 2006 10:32 jste napsal(a):
> On 11/12/06, Marek Vašut <marek.vasut@gmail.com> wrote:
> > Dne neděle 12 listopad 2006 19:30 jste napsal(a):
> > > Hi,
> > >
> > > when I turned on i2c on my omap310 based palmz71 and booted the kernel,
> > > it hanged. I´ve tracked the place where it hangs and fixed it. Here´s
> > > the small patch.
> >
> > forgot to add this ;-)
> >
> > Signed-off-by: Marek Vašut <marek.vasut@gmail.com>
>
> Just to confirm your patch comment. Did you enabled OMAP_DSP or I2C?
> as you had modified dsp_common.c. Going the generic way, dsp_common.c
> should pick up memory addresses from arch- specific files, but as
> omap_dsp_init is called in arch_init, I don't know, what would be the
> cleaner way to do it.

yes, I enabled i2c.

Re: [PATCH] ARM: OMAP: OMAP310 i2c fix

[Tony Lindgren]

* Marek Vašut <marek.vasut@gmail.com> [061113 09:16]:
> Dne pondělí 13 listopad 2006 10:32 jste napsal(a):
> > On 11/12/06, Marek Vašut <marek.vasut@gmail.com> wrote:
> > > Dne neděle 12 listopad 2006 19:30 jste napsal(a):
> > > > Hi,
> > > >
> > > > when I turned on i2c on my omap310 based palmz71 and booted the kernel,
> > > > it hanged. I´ve tracked the place where it hangs and fixed it. Here´s
> > > > the small patch.
> > >
> > > forgot to add this ;-)
> > >
> > > Signed-off-by: Marek Vašut <marek.vasut@gmail.com>
> >
> > Just to confirm your patch comment. Did you enabled OMAP_DSP or I2C?
> > as you had modified dsp_common.c. Going the generic way, dsp_common.c
> > should pick up memory addresses from arch- specific files, but as
> > omap_dsp_init is called in arch_init, I don't know, what would be the
> > cleaner way to do it.
> 
> yes, I enabled i2c.

Pushing this today.

Tony