Re: [PATCH] plat-omap changes for 2430 SDP

[David Brownell <david-b@pacbell.net>]

On Monday 13 November 2006 9:26 pm, Syed Mohammed, Khasim wrote:
> Hi Dave,
> 
> At present in our tree, we have "musb_plat" 
> (musb_hdrc_platform_data musb_plat) in our board_2430sdp.c. 

That's not in current linux-omap GIT.


> It's treated like flash or smc91.x device and added as another 2430SDP
> device to "__initdata " list. Do you see any issues with this approach?

Does it bind to the musb_hdrc driver?

The basic goal is to have the musb_hdrc driver bind to that platform
device, with its pins muxed appropriately, and able to talk propery
to the external transceiver.  The approach that's been taken so far is
to wrap the pin muxing, transceiver setup, and platform device setup
into one setup routine (in "devices.c"), and call that from the various
board-specific setup routines.  That's a bit more complex than fits well
into the simple "add to static device list" ... or at least it has been
for other USB controllers (e.g. the integrated full speed ones).

- Dave




> I think we need to discuss more on these sorts of placements. 
> 
> Thanks & Regards,
> Khasim
> 
> -----Original Message-----
> From: David Brownell [mailto:david-b@pacbell.net] 
> Sent: Monday, November 13, 2006 8:47 PM
> To: linux-omap-open-source@linux.omap.com
> Cc: Syed Mohammed, Khasim
> Subject: Re: [PATCH] plat-omap changes for 2430 SDP
> 
> Someone should also add an "musb_hdrc" platform device for
> the high speed OTG controller ... I figure that would basically
> live in mach-omap2/devices.c and be called from omap2430sdp_init().
> (I'm assuming that controller is accessible on the SDP...)
> 
> - Dave
>