From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH] plat-omap changes for 2430 SDP Date: Mon, 13 Nov 2006 22:44:01 -0800 Message-ID: <200611132244.01208.david-b@pacbell.net> References: <77C7F7CB1230A74A9D19C0C111E6EDBE01DFA5E0@DLEE09.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <77C7F7CB1230A74A9D19C0C111E6EDBE01DFA5E0@DLEE09.ent.ti.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: "Syed Mohammed, Khasim" Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org On Monday 13 November 2006 9:26 pm, Syed Mohammed, Khasim wrote: > Hi Dave, > > At present in our tree, we have "musb_plat" > (musb_hdrc_platform_data musb_plat) in our board_2430sdp.c. That's not in current linux-omap GIT. > It's treated like flash or smc91.x device and added as another 2430SDP > device to "__initdata " list. Do you see any issues with this approach? Does it bind to the musb_hdrc driver? The basic goal is to have the musb_hdrc driver bind to that platform device, with its pins muxed appropriately, and able to talk propery to the external transceiver. The approach that's been taken so far is to wrap the pin muxing, transceiver setup, and platform device setup into one setup routine (in "devices.c"), and call that from the various board-specific setup routines. That's a bit more complex than fits well into the simple "add to static device list" ... or at least it has been for other USB controllers (e.g. the integrated full speed ones). - Dave > I think we need to discuss more on these sorts of placements. > > Thanks & Regards, > Khasim > > -----Original Message----- > From: David Brownell [mailto:david-b@pacbell.net] > Sent: Monday, November 13, 2006 8:47 PM > To: linux-omap-open-source@linux.omap.com > Cc: Syed Mohammed, Khasim > Subject: Re: [PATCH] plat-omap changes for 2430 SDP > > Someone should also add an "musb_hdrc" platform device for > the high speed OTG controller ... I figure that would basically > live in mach-omap2/devices.c and be called from omap2430sdp_init(). > (I'm assuming that controller is accessible on the SDP...) > > - Dave >