From: Tony Lindgren <tony@atomide.com>
To: "Syed Mohammed, Khasim" <x0khasim@ti.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: Moving I2C2 init to plat-omap/devices.c ?
Date: Thu, 16 Nov 2006 03:01:33 +0200 [thread overview]
Message-ID: <20061116010133.GL21064@atomide.com> (raw)
In-Reply-To: <77C7F7CB1230A74A9D19C0C111E6EDBE01E41F96@DLEE09.ent.ti.com>
* Syed Mohammed, Khasim <x0khasim@ti.com> [061115 22:28]:
> Hello,
>
> I would like to enable I2C support for 2430. I see I2C1 device
> initialization defined in arch/arm/plat-omap/devices.c and I2C2 in
> arch/arm/mach-omap2/devices.c. I believe the reason for this might be to
> move the common part (I2C1) to plat-omap.
>
> I was thinking of moving the I2C2 initialization from
> mach-omap2/devices.c to plat-omap/devices.c. The reason is OMAP1 has 1
> I2C block, OMAP2 has 2 and OMAP3 has 4 (1 dedicated). The I2C register
> base addresses are same for 2420, 2430 and 3430. So, adding same code in
> two directories looks redundant.
>
> Let me know if you see any issues with this approach.
Well most of that code is just data for the ports. And it sounds like
you're assuming that omap3 is a separate directory and "completely different"
from omap2.. Until we've seen some patches and docs, I don't think we
can make that assumption.
Regards,
Tony
next prev parent reply other threads:[~2006-11-16 1:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 20:21 Moving I2C2 init to plat-omap/devices.c ? Syed Mohammed, Khasim
2006-11-16 1:01 ` Tony Lindgren [this message]
2006-11-16 1:21 ` Syed Mohammed, Khasim
2006-11-16 1:55 ` Tony Lindgren
2006-11-16 2:30 ` Woodruff, Richard
2006-11-16 9:29 ` Nishanth Menon
2006-11-16 14:58 ` Woodruff, Richard
2006-11-16 20:11 ` Nishanth Menon
2006-11-16 21:01 ` Tony Lindgren
2006-11-16 20:19 ` David Brownell
2006-11-16 20:55 ` Tony Lindgren
2006-11-16 21:29 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061116010133.GL21064@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=x0khasim@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox