public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Marek Vašut" <marek.vasut@gmail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH 1/4] ARM: OMAP: Palm Tungsten|T defconfig
Date: Thu, 16 Nov 2006 03:48:49 +0200	[thread overview]
Message-ID: <20061116014849.GP21064@atomide.com> (raw)
In-Reply-To: <200611120037.58048.marek.vasut@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

Hi,

* Marek Vašut <marek.vasut@gmail.com> [061112 01:48]:
> Hi,
> 
> I hope this time it'll be all ok ;-) (including formating)
> 
> This adds defconfig for Palm Tungsten|T.

Thanks, pushing your four patches, but had to still do formatting
for tabs and trailing whitespace, see below.. You may want to check
your editor settings :)

Regards,

Tony

[-- Attachment #2: errors --]
[-- Type: text/plain, Size: 8301 bytes --]

Tabifying non-tabbed line: "+       .name               = "write8k","
Tabifying non-tabbed line: "+       .offset             = 0,"
Tabifying non-tabbed line: "+       .size               = SZ_8K,"
Tabifying non-tabbed line: "+       .mask_flags         = 0,"
Tabifying non-tabbed line: "+       .name               = "PalmOS-BootLoader(ro)","
Tabifying non-tabbed line: "+       .offset             = SZ_8K,"
Tabifying non-tabbed line: "+       .size               = 7*SZ_8K,"
Tabifying non-tabbed line: "+       .mask_flags         = MTD_WRITEABLE,"
Tabifying non-tabbed line: "+       .name               = "u-boot","
Tabifying non-tabbed line: "+       .offset             = MTDPART_OFS_APPEND,"
Tabifying non-tabbed line: "+       .size               = 8*SZ_8K,"
Tabifying non-tabbed line: "+       .mask_flags         = 0,"
Tabifying non-tabbed line: "+       .name               = "PalmOS-FS(ro)","
Tabifying non-tabbed line: "+       .offset             = MTDPART_OFS_APPEND,"
Tabifying non-tabbed line: "+       .size               = 7*SZ_1M + 4*SZ_64K - 16*SZ_8K,"
Tabifying non-tabbed line: "+       .mask_flags         = MTD_WRITEABLE,"
Tabifying non-tabbed line: "+       .name               = "u-boot(rez)","
Tabifying non-tabbed line: "+       .offset             = MTDPART_OFS_APPEND,"
Tabifying non-tabbed line: "+       .size               = SZ_128K,"
Tabifying non-tabbed line: "+       .mask_flags         = 0"
Tabifying non-tabbed line: "+       .name               = "empty","
Tabifying non-tabbed line: "+       .offset             = MTDPART_OFS_APPEND,"
Tabifying non-tabbed line: "+       .size               = MTDPART_SIZ_FULL,"
Tabifying non-tabbed line: "+       .mask_flags         = 0"
Removing trailing whitespace: "+static struct omap_mcbsp_reg_cfg mcbsp_regs = { "
Tabifying non-tabbed line: "+                     RWDLEN2(OMAP_MCBSP_WORD_16) | RDATDLY(0),"
Tabifying non-tabbed line: "+                     RWDLEN1(OMAP_MCBSP_WORD_16),"
Tabifying non-tabbed line: "+                     XWDLEN2(OMAP_MCBSP_WORD_16) | XDATDLY(0) | XFIG,"
Tabifying non-tabbed line: "+                     XWDLEN1(OMAP_MCBSP_WORD_16),"
Tabifying non-tabbed line: "+                     FPER(DEFAULT_BITPERSAMPLE * 2 - 1),"
Removing trailing whitespace: "+        .get_default_samplerate = NULL, // aic23_get_default_samplerate,        "
Removing trailing whitespace: "+                                                        "
Tabifying non-tabbed line: "+       .start      = INT_UART3,"
Tabifying non-tabbed line: "+       .end        = INT_UART3,"
Tabifying non-tabbed line: "+       .flags      = IORESOURCE_IRQ,"
Removing trailing whitespace: "+                                                                                                               "
Removing trailing whitespace: "+                                                                                                               "
Removing trailing whitespace: "+        "
Removing trailing whitespace: "+        "
Tabifying non-tabbed line: "+       /* MicroWire (bus 2) CS0 has an ads7846e */"
Tabifying non-tabbed line: "+       .modalias           = "ads7846","
Tabifying non-tabbed line: "+       .platform_data      = &palmtt_ts_info,"
Tabifying non-tabbed line: "+       .irq                = OMAP_GPIO_IRQ(6),"
Tabifying non-tabbed line: "+       .max_speed_hz       = 120000        /* max sample rate at 3V */"
Tabifying non-tabbed line: "+                               * 26        /* command + data + overhead */,"
Tabifying non-tabbed line: "+       .bus_num            = 2,"
Tabifying non-tabbed line: "+       .chip_select        = 0,"
Removing trailing whitespace: "+        "
Tabifying non-tabbed line: "+        { OMAP_TAG_UART,   &palmtt_uart_config     },"
Removing trailing whitespace: "+                                                                                                "
Tabifying non-tabbed line: "+        if (mode)"
Tabifying non-tabbed line: "+       omap_writew(0x8000, OMAP_WDT_TIMER_MODE);"
Tabifying non-tabbed line: "+        else {"
Tabifying non-tabbed line: "+            omap_writew(0x00f5, OMAP_WDT_TIMER_MODE);"
Tabifying non-tabbed line: "+       omap_writew(0x00f5, OMAP_WDT_TIMER_MODE);"
Tabifying non-tabbed line: "+            omap_writew(0x00a0, OMAP_WDT_TIMER_MODE);"
Tabifying non-tabbed line: "+       omap_writew(0x00a0, OMAP_WDT_TIMER_MODE);"
Tabifying non-tabbed line: "+        }"
Tabifying non-tabbed line: "+        omap_mpu_wdt_mode(0);"
Tabifying non-tabbed line: "+        omap_board_config_size = ARRAY_SIZE(palmtt_config);"
Tabifying non-tabbed line: "+        spi_register_board_info(palmtt_boardinfo,ARRAY_SIZE(palmtt_boardinfo));"
Removing trailing whitespace: "+                                "
Tabifying non-tabbed line: "+                        struct omapfb_device *fbdev)"
Tabifying non-tabbed line: "+   .name           = "palmtt","
Tabifying non-tabbed line: "+   .config         = OMAP_LCDC_PANEL_TFT | OMAP_LCDC_INV_VSYNC |"
Tabifying non-tabbed line: "+                     OMAP_LCDC_INV_HSYNC | OMAP_LCDC_HSVS_RISING_EDGE |"
Tabifying non-tabbed line: "+    OMAP_LCDC_INV_HSYNC | OMAP_LCDC_HSVS_RISING_EDGE |"

Tabifying non-tabbed line: "+                     OMAP_LCDC_HSVS_OPPOSITE,"
Tabifying non-tabbed line: "+    OMAP_LCDC_HSVS_OPPOSITE,"
Tabifying non-tabbed line: "+   .bpp            = 16,"
Tabifying non-tabbed line: "+   .x_res          = 320,"
Tabifying non-tabbed line: "+   .y_res          = 320,"
Tabifying non-tabbed line: "+   .hsw            = 4,"
Tabifying non-tabbed line: "+   .hfp            = 8,"
Tabifying non-tabbed line: "+   .hbp            = 28,"
Tabifying non-tabbed line: "+   .vsw            = 1,"
Tabifying non-tabbed line: "+   .vfp            = 8,"
Tabifying non-tabbed line: "+   .vbp            = 7,"
Tabifying non-tabbed line: "+   .pcd            = 0,"
Tabifying non-tabbed line: "+   .init           = palmtt_panel_init,"
Tabifying non-tabbed line: "+   .enable         = palmtt_panel_enable,"
Tabifying non-tabbed line: "+   .probe          = palmtt_panel_probe,"
Tabifying non-tabbed line: "+   .remove         = palmtt_panel_remove,"
Tabifying non-tabbed line: "+   .resume         = palmtt_panel_resume,"
Tabifying non-tabbed line: "+   .driver         = {"
Tabifying non-tabbed line: "+           .name   = "lcd_palmtt","
Tabifying non-tabbed line: "+           .owner  = THIS_MODULE,"

Tabifying non-tabbed line: "+   .spcr2          = FREE | FRST | GRST | XRST | XINTM(3),"
Tabifying non-tabbed line: "+   .spcr1          = RINTM(3) | RRST,"
Tabifying non-tabbed line: "+   .rcr2           = RPHASE | RFRLEN2(OMAP_MCBSP_WORD_8) |"
Tabifying non-tabbed line: "+                     RWDLEN2(OMAP_MCBSP_WORD_16) | RDATDLY(0),"
Tabifying non-tabbed line: "+    RWDLEN2(OMAP_MCBSP_WORD_16) | RDATDLY(0),"
Tabifying non-tabbed line: "+   .rcr1           = RFRLEN1(OMAP_MCBSP_WORD_8) | RWDLEN1(OMAP_MCBSP_WORD_16),"
Tabifying non-tabbed line: "+   .xcr2           = XPHASE | XFRLEN2(OMAP_MCBSP_WORD_8) |"
Tabifying non-tabbed line: "+                     XWDLEN2(OMAP_MCBSP_WORD_16) | XDATDLY(0) | XFIG,"
Tabifying non-tabbed line: "+    XWDLEN2(OMAP_MCBSP_WORD_16) | XDATDLY(0) | XFIG,"
Tabifying non-tabbed line: "+   .xcr1           = XFRLEN1(OMAP_MCBSP_WORD_8) | XWDLEN1(OMAP_MCBSP_WORD_16),"
Tabifying non-tabbed line: "+   .srgr1          = FWID(DEFAULT_BITPERSAMPLE - 1),"
Tabifying non-tabbed line: "+   .srgr2          = GSYNC | CLKSP | FSGM | FPER(DEFAULT_BITPERSAMPLE * 2 - 1),"
Tabifying non-tabbed line: "+   .pcr0           = CLKXP | CLKRP,        /* mcbsp: slave */"
Tabifying non-tabbed line: "+    {"
Tabifying non-tabbed line: "+   .irq            = OMAP_GPIO_IRQ(PALMZ71_PENIRQ_GPIO),"
Tabifying non-tabbed line: "+                     * 26          /* command + data + overhead */,"
Tabifying non-tabbed line: "+    * 26           /* command + data + overhead */,"
Tabifying non-tabbed line: "+    }"
Tabifying non-tabbed line: "+               palmz71_powercable, SA_SAMPLE_RANDOM, "palmz71-cable", 0))"
Tabifying non-tabbed line: "+     palmz71_powercable, SA_SAMPLE_RANDOM, "palmz71-cable", 0))"
Tabifying non-tabbed line: "+                   printk(KERN_ERR"
Tabifying non-tabbed line: "+                           "IRQ request for power cable failed!\n");"

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



      reply	other threads:[~2006-11-16  1:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-11 23:37 [PATCH 1/4] ARM: OMAP: Palm Tungsten|T defconfig Marek Vašut
2006-11-16  1:48 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061116014849.GP21064@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=marek.vasut@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox