From: Tony Lindgren <tony@atomide.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [patch 2.6.19-rc6-omap] fix rng platform device init
Date: Tue, 28 Nov 2006 02:30:02 +0000 [thread overview]
Message-ID: <20061128023001.GE7763@atomide.com> (raw)
In-Reply-To: <20061124181217.73146196734@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
* David Brownell <david-b@pacbell.net> [061124 18:13]:
> The platform device needed for /dev/hw_random wasn't being created
> correctly; it used the wrong CONFIG symbol(s).
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> ----
> FYI, output of one "rngtest" run on a mostly-idle OSK:
>
> Indet: starting FIPS tests...
> rngtest: bits received from input: 23479480032
> rngtest: FIPS 140-2 successes: 1173013
> rngtest: FIPS 140-2 failures: 961
> rngtest: FIPS 140-2(2001-10-10) Monobit: 124
> rngtest: FIPS 140-2(2001-10-10) Poker: 115
> rngtest: FIPS 140-2(2001-10-10) Runs: 360
> rngtest: FIPS 140-2(2001-10-10) Long run: 368
> rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
> rngtest: input channel speed: (min=274.323; avg=968.504; max=1807.947)Kibits/s
> rngtest: FIPS tests speed: (min=1.371; avg=5.956; max=6.129)Mibits/s
> rngtest: Program run time: 27463201721 microseconds
>
>
> --- osk2.orig/arch/arm/plat-omap/devices.c 2006-11-17 16:36:48.000000000 -0800
> +++ osk2/arch/arm/plat-omap/devices.c 2006-11-24 09:57:46.000000000 -0800
> @@ -440,7 +440,7 @@ static inline void omap_init_wdt(void) {
>
> /*-------------------------------------------------------------------------*/
>
> -#if defined(CONFIG_OMAP_RNG) || defined(CONFIG_OMAP_RNG_MODULE)
> +#if defined(CONFIG_HW_RANDOM_OMAP) || defined(CONFIG_HW_RANDOM_OMAP_MODULE)
>
> #ifdef CONFIG_ARCH_OMAP24XX
> #define OMAP_RNG_BASE 0x480A0000
Thanks, pushing today.
Tony
prev parent reply other threads:[~2006-11-28 2:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-24 18:12 [patch 2.6.19-rc6-omap] fix rng platform device init David Brownell
2006-11-28 2:30 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061128023001.GE7763@atomide.com \
--to=tony@atomide.com \
--cc=david-b@pacbell.net \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox