[PATCH] ARM: OMAP: Remove unnecessary memset in dsp task.c

[PATCH] ARM: OMAP: Remove unnecessary memset in dsp task.c

[Komal Shah]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

There is much more duplicated code can be removed in task.c by using
already available wait_for_event_{un}interruptible_{timeout},
prepare_wait, finish_wait etc calls. What do you say?

-- 
---Komal Shah
http://komalshah.blogspot.com

[-- Attachment #2: 0001-ARM-OMAP-Remove-unnecessary-memset-in-dsp-task.c.txt --]
[-- Type: text/plain, Size: 1109 bytes --]

From 4e89cea55f7aa2162a7541106443eef609666ed0 Mon Sep 17 00:00:00 2001
From: Komal Shah <komal_shah802003@yahoo.com>
Date: Mon, 4 Dec 2006 23:52:11 +0530
Subject: [PATCH] ARM: OMAP: Remove unnecessary memset in dsp task.c

- and remove commented "struct device_driver"

Signed-off-by: Komal Shah <komal_shah802003@yahoo.com>
---
 arch/arm/plat-omap/dsp/task.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/arm/plat-omap/dsp/task.c b/arch/arm/plat-omap/dsp/task.c
index 7fcc06a..807c408 100644
--- a/arch/arm/plat-omap/dsp/task.c
+++ b/arch/arm/plat-omap/dsp/task.c
@@ -108,7 +108,6 @@ struct rcvdt_bk_struct {
 
 struct taskdev {
 	struct bus_type *bus;
-//	struct device_driver *driver;
 	struct device dev;	/* Generic device interface */
 
 	long state;
@@ -564,9 +563,6 @@ int dsp_task_config_all(u8 n)
 	struct dsptask *taskheap;
 	size_t devheapsz, taskheapsz;
 
-	memset(taskdev, 0, sizeof(void *) * TASKDEV_MAX);
-	memset(dsptask, 0, sizeof(void *) * TASKDEV_MAX);
-
 	printk(KERN_INFO "omapdsp: found %d task(s)\n", n);
 	if (n == 0)
 		return 0;
-- 
1.4.3.4.g82cc


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ARM: OMAP: Remove unnecessary memset in dsp task.c

[Hiroshi DOYU]

From: "ext Komal Shah" <komal.shah802003@gmail.com>
Subject: [PATCH] ARM: OMAP: Remove unnecessary memset in dsp task.c
Date: Mon, 4 Dec 2006 23:57:26 +0530

> There is much more duplicated code can be removed in task.c by using
> already available wait_for_event_{un}interruptible_{timeout},
> prepare_wait, finish_wait etc calls. What do you say?

Yes, it is;) I already have it and I will try to get them back.

BTW, for memset, I thought that the residual code is in the one in
"dsp_taskmod_init()", isn't it?

    Hiroshi DOYU

Re: [PATCH] ARM: OMAP: Remove unnecessary memset in dsp task.c

[Tony Lindgren]

* Komal Shah <komal.shah802003@gmail.com> [061204 10:33]:
> There is much more duplicated code can be removed in task.c by using
> already available wait_for_event_{un}interruptible_{timeout},
> prepare_wait, finish_wait etc calls. What do you say?
> 
> -- 
> ---Komal Shah
> http://komalshah.blogspot.com

> From 4e89cea55f7aa2162a7541106443eef609666ed0 Mon Sep 17 00:00:00 2001
> From: Komal Shah <komal_shah802003@yahoo.com>
> Date: Mon, 4 Dec 2006 23:52:11 +0530
> Subject: [PATCH] ARM: OMAP: Remove unnecessary memset in dsp task.c
> 
> - and remove commented "struct device_driver"
> 
> Signed-off-by: Komal Shah <komal_shah802003@yahoo.com>
> ---
>  arch/arm/plat-omap/dsp/task.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/dsp/task.c b/arch/arm/plat-omap/dsp/task.c
> index 7fcc06a..807c408 100644
> --- a/arch/arm/plat-omap/dsp/task.c
> +++ b/arch/arm/plat-omap/dsp/task.c
> @@ -108,7 +108,6 @@ struct rcvdt_bk_struct {
>  
>  struct taskdev {
>  	struct bus_type *bus;
> -//	struct device_driver *driver;
>  	struct device dev;	/* Generic device interface */
>  
>  	long state;
> @@ -564,9 +563,6 @@ int dsp_task_config_all(u8 n)
>  	struct dsptask *taskheap;
>  	size_t devheapsz, taskheapsz;
>  
> -	memset(taskdev, 0, sizeof(void *) * TASKDEV_MAX);
> -	memset(dsptask, 0, sizeof(void *) * TASKDEV_MAX);
> -
>  	printk(KERN_INFO "omapdsp: found %d task(s)\n", n);
>  	if (n == 0)
>  		return 0;

Pushing today.

Tony