public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dmtimer.c omap1 register fix...
@ 2006-12-08  0:52 Matthew Percival
  2006-12-21 22:52 ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Matthew Percival @ 2006-12-08  0:52 UTC (permalink / raw)
  To: Linux OMAP Open Source

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

G'Day,

	When I went to use dmtimer7 it did not seem to work.  I noticed that
the base addresses for dmtimers 7 and 8 were set wrong.  A simple patch
to correct a small error.  Confirmed to fix the problem on an OSK.

	-- Matthew

[-- Attachment #2: dmtimer.c.patch --]
[-- Type: text/x-patch, Size: 599 bytes --]

--- a/arch/arm/plat-omap/dmtimer.c	2006-12-06 11:40:06.000000000 +1100
+++ b/arch/arm/plat-omap/dmtimer.c	2006-12-08 11:47:33.000000000 +1100
@@ -90,8 +90,8 @@
 	{ .phys_base = 0xfffb2c00, .irq = INT_1610_GPTIMER4 },
 	{ .phys_base = 0xfffb3400, .irq = INT_1610_GPTIMER5 },
 	{ .phys_base = 0xfffb3c00, .irq = INT_1610_GPTIMER6 },
-	{ .phys_base = 0xfffb4400, .irq = INT_1610_GPTIMER7 },
-	{ .phys_base = 0xfffb4c00, .irq = INT_1610_GPTIMER8 },
+	{ .phys_base = 0xfffb7400, .irq = INT_1610_GPTIMER7 },
+	{ .phys_base = 0xfffbd400, .irq = INT_1610_GPTIMER8 },
 };
 
 #elif defined(CONFIG_ARCH_OMAP2)

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dmtimer.c omap1 register fix...
  2006-12-08  0:52 [PATCH] dmtimer.c omap1 register fix Matthew Percival
@ 2006-12-21 22:52 ` Tony Lindgren
  2006-12-21 23:13   ` Matthew Percival
  0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2006-12-21 22:52 UTC (permalink / raw)
  To: Matthew Percival; +Cc: Linux OMAP Open Source

* Matthew Percival <matthew@capgo.com> [061207 16:54]:
> G'Day,
> 
> 	When I went to use dmtimer7 it did not seem to work.  I noticed that
> the base addresses for dmtimers 7 and 8 were set wrong.  A simple patch
> to correct a small error.  Confirmed to fix the problem on an OSK.
> 
> 	-- Matthew

> --- a/arch/arm/plat-omap/dmtimer.c	2006-12-06 11:40:06.000000000 +1100
> +++ b/arch/arm/plat-omap/dmtimer.c	2006-12-08 11:47:33.000000000 +1100
> @@ -90,8 +90,8 @@
>  	{ .phys_base = 0xfffb2c00, .irq = INT_1610_GPTIMER4 },
>  	{ .phys_base = 0xfffb3400, .irq = INT_1610_GPTIMER5 },
>  	{ .phys_base = 0xfffb3c00, .irq = INT_1610_GPTIMER6 },
> -	{ .phys_base = 0xfffb4400, .irq = INT_1610_GPTIMER7 },
> -	{ .phys_base = 0xfffb4c00, .irq = INT_1610_GPTIMER8 },
> +	{ .phys_base = 0xfffb7400, .irq = INT_1610_GPTIMER7 },
> +	{ .phys_base = 0xfffbd400, .irq = INT_1610_GPTIMER8 },
>  };
>  
>  #elif defined(CONFIG_ARCH_OMAP2)

Good catch, can you please reply to this thread with your Signed-off-by?

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dmtimer.c omap1 register fix...
  2006-12-21 22:52 ` Tony Lindgren
@ 2006-12-21 23:13   ` Matthew Percival
  2006-12-21 23:40     ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Matthew Percival @ 2006-12-21 23:13 UTC (permalink / raw)
  To: Linux OMAP Open Source

On Thu, 2006-12-21 at 14:52 -0800, Tony Lindgren wrote:
> * Matthew Percival <matthew@capgo.com> [061207 16:54]:
> > G'Day,
> > 
> > 	When I went to use dmtimer7 it did not seem to work.  I noticed that
> > the base addresses for dmtimers 7 and 8 were set wrong.  A simple patch
> > to correct a small error.  Confirmed to fix the problem on an OSK.
> > 
> > 	-- Matthew
> 
> > --- a/arch/arm/plat-omap/dmtimer.c	2006-12-06 11:40:06.000000000 +1100
> > +++ b/arch/arm/plat-omap/dmtimer.c	2006-12-08 11:47:33.000000000 +1100
> > @@ -90,8 +90,8 @@
> >  	{ .phys_base = 0xfffb2c00, .irq = INT_1610_GPTIMER4 },
> >  	{ .phys_base = 0xfffb3400, .irq = INT_1610_GPTIMER5 },
> >  	{ .phys_base = 0xfffb3c00, .irq = INT_1610_GPTIMER6 },
> > -	{ .phys_base = 0xfffb4400, .irq = INT_1610_GPTIMER7 },
> > -	{ .phys_base = 0xfffb4c00, .irq = INT_1610_GPTIMER8 },
> > +	{ .phys_base = 0xfffb7400, .irq = INT_1610_GPTIMER7 },
> > +	{ .phys_base = 0xfffbd400, .irq = INT_1610_GPTIMER8 },
> >  };
> >  
> >  #elif defined(CONFIG_ARCH_OMAP2)
> 
> Good catch, can you please reply to this thread with your Signed-off-by?
> 
> Tony

Signed-off-by: Matthew Percival <matthew at capgo.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dmtimer.c omap1 register fix...
  2006-12-21 23:13   ` Matthew Percival
@ 2006-12-21 23:40     ` Tony Lindgren
  0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2006-12-21 23:40 UTC (permalink / raw)
  To: Matthew Percival; +Cc: Linux OMAP Open Source

* Matthew Percival <matthew@capgo.com> [061221 15:14]:
> On Thu, 2006-12-21 at 14:52 -0800, Tony Lindgren wrote:
> > * Matthew Percival <matthew@capgo.com> [061207 16:54]:
> > > G'Day,
> > > 
> > > 	When I went to use dmtimer7 it did not seem to work.  I noticed that
> > > the base addresses for dmtimers 7 and 8 were set wrong.  A simple patch
> > > to correct a small error.  Confirmed to fix the problem on an OSK.
> > > 
> > > 	-- Matthew
> > 
> > > --- a/arch/arm/plat-omap/dmtimer.c	2006-12-06 11:40:06.000000000 +1100
> > > +++ b/arch/arm/plat-omap/dmtimer.c	2006-12-08 11:47:33.000000000 +1100
> > > @@ -90,8 +90,8 @@
> > >  	{ .phys_base = 0xfffb2c00, .irq = INT_1610_GPTIMER4 },
> > >  	{ .phys_base = 0xfffb3400, .irq = INT_1610_GPTIMER5 },
> > >  	{ .phys_base = 0xfffb3c00, .irq = INT_1610_GPTIMER6 },
> > > -	{ .phys_base = 0xfffb4400, .irq = INT_1610_GPTIMER7 },
> > > -	{ .phys_base = 0xfffb4c00, .irq = INT_1610_GPTIMER8 },
> > > +	{ .phys_base = 0xfffb7400, .irq = INT_1610_GPTIMER7 },
> > > +	{ .phys_base = 0xfffbd400, .irq = INT_1610_GPTIMER8 },
> > >  };
> > >  
> > >  #elif defined(CONFIG_ARCH_OMAP2)
> > 
> > Good catch, can you please reply to this thread with your Signed-off-by?
> > 
> > Tony
> 
> Signed-off-by: Matthew Percival <matthew at capgo.com>

Thanks, pushing today.

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-12-21 23:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-08  0:52 [PATCH] dmtimer.c omap1 register fix Matthew Percival
2006-12-21 22:52 ` Tony Lindgren
2006-12-21 23:13   ` Matthew Percival
2006-12-21 23:40     ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox