* Re: [PATCH]: Workqueue changes for board-h3 [not found] <31e679430612280750l77e590e4ice853ef8b4c3d05f@mail.gmail.com> @ 2006-12-28 19:33 ` Komal Shah 2007-01-02 20:35 ` tony 0 siblings, 1 reply; 3+ messages in thread From: Komal Shah @ 2006-12-28 19:33 UTC (permalink / raw) To: Felipe Balbi; +Cc: linux-omap-open-source On 12/28/06, Felipe Balbi <felipebalbi@users.sourceforge.net> wrote: > Hello Komal, > >> -static void set_trans_mode(void *data) > >> +static void set_trans_mode(struct work_struct *data) > >> { > >> - int *mode = data; > >> + int *mode = (int *)data; > > >Did you tested this patch.? I am not sure this casting is the correct > >way to go for it. > > I'm wondering if that > >> + int *mode = (int *)data; > > shouldn't be > int *mode = (int *) data->data; > > the second data is a atomic_long_t witch is a volatile int... > > What does it mean these IrDA Flags?? > > #define IR_SEL 1 /* Selects IrDA */ Above is customized flag for H4/H3 EVM, as we need to select between the IrDA and aGPS module by programming through gpio expander. see board-h4.c and board-h3.c for its usage (for enabling/disabling the IR TX/RX). > #define IR_SIRMODE 2 > #define IR_FIRMODE 4 > #define IR_MIRMODE 8 > Above three denotes the capabilities of the transeciver, meaning which speeds are supported by it. -- ---Komal Shah http://komalshah.blogspot.com ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]: Workqueue changes for board-h3 2006-12-28 19:33 ` [PATCH]: Workqueue changes for board-h3 Komal Shah @ 2007-01-02 20:35 ` tony 0 siblings, 0 replies; 3+ messages in thread From: tony @ 2007-01-02 20:35 UTC (permalink / raw) To: Komal Shah; +Cc: linux-omap-open-source * Komal Shah <komal.shah802003@gmail.com> [061228 11:43]: > On 12/28/06, Felipe Balbi <felipebalbi@users.sourceforge.net> wrote: > >Hello Komal, > >>> -static void set_trans_mode(void *data) > >>> +static void set_trans_mode(struct work_struct *data) > >>> { > >>> - int *mode = data; > >>> + int *mode = (int *)data; > > > >>Did you tested this patch.? I am not sure this casting is the correct > >>way to go for it. > > > >I'm wondering if that > >>> + int *mode = (int *)data; > > > >shouldn't be > >int *mode = (int *) data->data; > > > >the second data is a atomic_long_t witch is a volatile int... > > > >What does it mean these IrDA Flags?? > > > >#define IR_SEL 1 /* Selects IrDA */ > > Above is customized flag for H4/H3 EVM, as we need to select between > the IrDA and aGPS module by programming through gpio expander. see > board-h4.c and board-h3.c for its usage (for enabling/disabling the IR > TX/RX). > > >#define IR_SIRMODE 2 > >#define IR_FIRMODE 4 > >#define IR_MIRMODE 8 > > > > Above three denotes the capabilities of the transeciver, meaning which > speeds are supported by it. Can you please try Dirk's patch for H3? Tony ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20061228132843.6403.qmail@web33710.mail.mud.yahoo.com>]
* Fwd: [PATCH]: Workqueue changes for board-h3 [not found] <20061228132843.6403.qmail@web33710.mail.mud.yahoo.com> @ 2006-12-28 13:31 ` Ragner N Magalhães 2006-12-28 14:48 ` Komal Shah 0 siblings, 1 reply; 3+ messages in thread From: Ragner N Magalhães @ 2006-12-28 13:31 UTC (permalink / raw) To: linux-omap-open-source ---------- Forwarded message ---------- From: Felipe Balbi <felipe.lima@indt.org.br> Date: Dec 28, 2006 9:28 AM Subject: [PATCH]: Workqueue changes for board-h3 To: ragner.magalhaes@gmail.com Hello all, This patch fixes an error regarding workqueue changes on board-h3 file.] =================== CUT HERE ========================== Fixes a compile issue when using CONFIG_MACH_OMAP_H3 regarding workqueues. Signed-off-by: Felipe Balbi <felipe.lima@indt.org.br> --- Index: linux-omap-2.6-dev/arch/arm/mach-omap1/board-h3.c =================================================================== --- linux-omap-2.6-dev.orig/arch/arm/mach-omap1/board-h3.c +++ linux-omap-2.6-dev/arch/arm/mach-omap1/board-h3.c @@ -298,5 +298,5 @@ static int h3_select_irda(struct device -static void set_trans_mode(void *data) +static void set_trans_mode(struct work_struct *data) { - int *mode = data; + int *mode = (int *)data; unsigned char expa; @@ -321,3 +321,3 @@ static void set_trans_mode(void *data) -static int h3_transceiver_mode(struct device *dev, int mode) +static int h3_transceiver_mode(struct device *dev) { @@ -326,4 +326,3 @@ static int h3_transceiver_mode(struct de cancel_delayed_work(&irda_config->gpio_expa); - PREPARE_WORK(&irda_config->gpio_expa, set_trans_mode, &mode); -#error this is not permitted - mode is an argument variable + PREPARE_WORK(&(irda_config->gpio_expa.work), set_trans_mode); schedule_delayed_work(&irda_config->gpio_expa, 0); Index: linux-omap-2.6-dev/include/asm-arm/arch-omap/irda.h =================================================================== --- linux-omap-2.6-dev.orig/include/asm-arm/arch-omap/irda.h +++ linux-omap-2.6-dev/include/asm-arm/arch-omap/irda.h @@ -21,3 +21,3 @@ struct omap_irda_config { int transceiver_cap; - int (*transceiver_mode)(struct device *dev, int mode); + int (*transceiver_mode)(struct device *dev); int (*select_irda)(struct device *dev, int state); Best Regards, Felipe Balbi felipe.lima@indt.org.br Nokia Institute of Technology - INdT Kernel Developers Team +55 92 8127 0839 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]: Workqueue changes for board-h3 2006-12-28 13:31 ` Fwd: " Ragner N Magalhães @ 2006-12-28 14:48 ` Komal Shah 0 siblings, 0 replies; 3+ messages in thread From: Komal Shah @ 2006-12-28 14:48 UTC (permalink / raw) To: Ragner N Magalhães; +Cc: linux-omap-open-source On 12/28/06, Ragner N Magalhães <ragner@users.sourceforge.net> wrote: > ---------- Forwarded message ---------- > From: Felipe Balbi <felipe.lima@indt.org.br> > Date: Dec 28, 2006 9:28 AM > Subject: [PATCH]: Workqueue changes for board-h3 > To: ragner.magalhaes@gmail.com > > Hello all, > > > This patch fixes an error regarding workqueue changes on board-h3 file.] > > > > =================== CUT HERE ========================== > Fixes a compile issue when using CONFIG_MACH_OMAP_H3 regarding workqueues. > > Signed-off-by: Felipe Balbi <felipe.lima@indt.org.br> > --- > > Index: linux-omap-2.6-dev/arch/arm/mach-omap1/board-h3.c > =================================================================== > --- linux-omap-2.6-dev.orig/arch/arm/mach-omap1/board-h3.c > +++ linux-omap-2.6-dev/arch/arm/mach-omap1/board-h3.c > @@ -298,5 +298,5 @@ static int h3_select_irda(struct device > > -static void set_trans_mode(void *data) > +static void set_trans_mode(struct work_struct *data) > { > - int *mode = data; > + int *mode = (int *)data; Did you tested this patch.? I am not sure this casting is the correct way to go for it. -- ---Komal Shah http://komalshah.blogspot.com ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-01-02 20:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <31e679430612280750l77e590e4ice853ef8b4c3d05f@mail.gmail.com>
2006-12-28 19:33 ` [PATCH]: Workqueue changes for board-h3 Komal Shah
2007-01-02 20:35 ` tony
[not found] <20061228132843.6403.qmail@web33710.mail.mud.yahoo.com>
2006-12-28 13:31 ` Fwd: " Ragner N Magalhães
2006-12-28 14:48 ` Komal Shah
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox