From: Tony Lindgren <tony@atomide.com>
To: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] lcd_mipid: workqueue fixes
Date: Tue, 9 Jan 2007 15:34:49 -0800 [thread overview]
Message-ID: <20070109233448.GR7384@atomide.com> (raw)
In-Reply-To: <85mz4tesfy.fsf@orfeo.duckcorp.org>
* Arnaud Patard <arnaud.patard@rtp-net.org> [070108 02:15]:
>
> This patch fixes the build of the lcd_mipid in current omap -git.
>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> ---
> ---
> drivers/video/omap/lcd_mipid.c | 10 5 + 5 - 0 !
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> Index: linux-omap-2.6/drivers/video/omap/lcd_mipid.c
> ===================================================================
> --- linux-omap-2.6.orig/drivers/video/omap/lcd_mipid.c 2007-01-07 20:13:21.000000000 +0100
> +++ linux-omap-2.6/drivers/video/omap/lcd_mipid.c 2007-01-07 20:53:37.000000000 +0100
> @@ -67,7 +67,7 @@ struct mipid_device {
> struct lcd_panel panel;
>
> struct workqueue_struct *esd_wq;
> - struct work_struct esd_work;
> + struct delayed_work esd_work;
> void (*esd_check)(struct mipid_device *m);
> };
>
> @@ -390,9 +390,9 @@ static void mipid_esd_stop_check(struct
> cancel_rearming_delayed_workqueue(md->esd_wq, &md->esd_work);
> }
>
> -static void mipid_esd_work(void *data)
> +static void mipid_esd_work(struct work_struct *work)
> {
> - struct mipid_device *md = data;
> + struct mipid_device *md = container_of(work, struct mipid_device, esd_work.work);
>
> mutex_lock(&md->mutex);
> md->esd_check(md);
> @@ -468,7 +468,7 @@ static int mipid_init(struct lcd_panel *
> dev_err(&md->spi->dev, "can't create ESD workqueue\n");
> return -ENOMEM;
> }
> - INIT_WORK(&md->esd_work, mipid_esd_work, md);
> + INIT_DELAYED_WORK(&md->esd_work, mipid_esd_work);
> mutex_init(&md->mutex);
>
> md->enabled = panel_enabled(md);
> @@ -558,7 +558,7 @@ static int mipid_spi_probe(struct spi_de
> struct mipid_device *md;
> int r;
>
> - md = kzalloc(sizeof(*md), SLAB_KERNEL);
> + md = kzalloc(sizeof(*md), GFP_KERNEL);
> if (md == NULL) {
> dev_err(&md->spi->dev, "out of memory\n");
> return -ENOMEM;
Pushing today.
Tony
prev parent reply other threads:[~2007-01-09 23:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-08 10:14 [PATCH] lcd_mipid: workqueue fixes Arnaud Patard
2007-01-09 23:34 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070109233448.GR7384@atomide.com \
--to=tony@atomide.com \
--cc=arnaud.patard@rtp-net.org \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox