Re: [patch 0/3] musb_hdrc, remove MGC_{Read,Write}Csr{8,16}

[David Brownell <david-b@pacbell.net>]

On Monday 22 January 2007 1:19 pm, Tony Lindgren wrote:

> OK, BTW looks like I'm not getting any VBUS on N800.
> If I ground ID pin and feed back VBUS from hub to N800, then it
> enumerates. (This is with maemo.org 2.6.18 tree)

Hmm, maybe they didn't populate the caps for the chargepump?
If you ground it, VBUS should come automagically.

Here's a patch that addresses one issue I know about.  But
another couple issues joined recently ... not quit sure what's
up with those yet.

- Dave

==============
Recent usbcore "autosuspend" changes redefined the interface for root hubs
in an incompatible way.  This patch makes CONNECT irqs work again.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

--- h4.orig/drivers/usb/musb/plat_uds.c	2007-01-19 16:43:36.000000000 -0800
+++ h4/drivers/usb/musb/plat_uds.c	2007-01-19 16:43:31.000000000 -0800
@@ -472,9 +472,11 @@ static irqreturn_t musb_stage0_irq(struc
 	}
 
 	if (bIntrUSB & MGC_M_INTR_CONNECT) {
+		struct usb_hcd *hcd = musb_to_hcd(pThis);
+
 		handled = IRQ_HANDLED;
 		pThis->is_active = 1;
-		set_bit(HCD_FLAG_SAW_IRQ, &musb_to_hcd(pThis)->flags);
+		set_bit(HCD_FLAG_SAW_IRQ, &hcd->flags);
 
 		pThis->bEnd0Stage = MGC_END0_START;
 
@@ -496,7 +498,10 @@ static irqreturn_t musb_stage0_irq(struc
 		if (devctl & MGC_M_DEVCTL_LSDEV)
 			pThis->port1_status |= USB_PORT_STAT_LOW_SPEED;
 
-		usb_hcd_poll_rh_status(musb_to_hcd(pThis));
+		if (hcd->status_urb)
+			usb_hcd_poll_rh_status(hcd);
+		else
+			usb_hcd_resume_root_hub(hcd);
 
 		MUSB_HST_MODE(pThis);