* [PATCH] dsp: don't use registered_fb[1]
@ 2007-01-14 13:38 Arnaud Patard
2007-01-26 21:51 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Arnaud Patard @ 2007-01-14 13:38 UTC (permalink / raw)
To: linux-omap-open-source
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
According to dsp_fbexport(), the dsp code handles only the first
registered framebuffer, so using registered_fb[1] in mbox_fbctl_upd is
wrong. registered_fb[0] must be used instead.
This code has also the side effect to oops the kernel as
registered_fb[1] is null and omapfb_update_window_async doesn't handle
this case. The fix for omapfb_update_window_async is sent in an other
mail.
Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
---
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dsp_mem_registered_fb_fix.patch --]
[-- Type: text/x-diff, Size: 714 bytes --]
---
arch/arm/plat-omap/dsp/dsp_mem.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c
===================================================================
--- linux-omap-2.6.orig/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:26.000000000 +0100
+++ linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:37.000000000 +0100
@@ -2052,7 +2052,7 @@ void mbox_fbctl_upd(void)
return;
}
//printk("calling omapfb_update_window_async()\n");
- omapfb_update_window_async(registered_fb[1], &win, fbupd_cb, NULL);
+ omapfb_update_window_async(registered_fb[0], &win, fbupd_cb, NULL);
}
#else /* CONFIG_FB_OMAP_LCDC_EXTERNAL */
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dsp: don't use registered_fb[1]
2007-01-14 13:38 [PATCH] dsp: don't use registered_fb[1] Arnaud Patard
@ 2007-01-26 21:51 ` Tony Lindgren
2007-01-28 5:13 ` Hiroshi DOYU
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2007-01-26 21:51 UTC (permalink / raw)
To: Arnaud Patard, Toshihiro Kobayashi, Hiroshi DOYU; +Cc: linux-omap-open-source
* Arnaud Patard <arnaud.patard@rtp-net.org> [070114 05:45]:
>
> According to dsp_fbexport(), the dsp code handles only the first
> registered framebuffer, so using registered_fb[1] in mbox_fbctl_upd is
> wrong. registered_fb[0] must be used instead.
> This code has also the side effect to oops the kernel as
> registered_fb[1] is null and omapfb_update_window_async doesn't handle
> this case. The fix for omapfb_update_window_async is sent in an other
> mail.
>
>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> ---
> ---
> arch/arm/plat-omap/dsp/dsp_mem.c | 2 1 + 1 - 0 !
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:26.000000000 +0100
> +++ linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:37.000000000 +0100
> @@ -2052,7 +2052,7 @@ void mbox_fbctl_upd(void)
> return;
> }
> //printk("calling omapfb_update_window_async()\n");
> - omapfb_update_window_async(registered_fb[1], &win, fbupd_cb, NULL);
> + omapfb_update_window_async(registered_fb[0], &win, fbupd_cb, NULL);
> }
>
> #else /* CONFIG_FB_OMAP_LCDC_EXTERNAL */
Toshihiro and Hiroshi, can you ack this one?
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dsp: don't use registered_fb[1]
2007-01-26 21:51 ` Tony Lindgren
@ 2007-01-28 5:13 ` Hiroshi DOYU
2007-01-31 18:58 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Hiroshi DOYU @ 2007-01-28 5:13 UTC (permalink / raw)
To: tony; +Cc: linux-omap-open-source
Acked.
From: "ext Tony Lindgren" <tony@atomide.com>
Subject: Re: [PATCH] dsp: don't use registered_fb[1]
Date: Fri, 26 Jan 2007 13:51:24 -0800
> * Arnaud Patard <arnaud.patard@rtp-net.org> [070114 05:45]:
> >
> > According to dsp_fbexport(), the dsp code handles only the first
> > registered framebuffer, so using registered_fb[1] in mbox_fbctl_upd is
> > wrong. registered_fb[0] must be used instead.
> > This code has also the side effect to oops the kernel as
> > registered_fb[1] is null and omapfb_update_window_async doesn't handle
> > this case. The fix for omapfb_update_window_async is sent in an other
> > mail.
> >
> >
> > Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> > ---
>
> > ---
> > arch/arm/plat-omap/dsp/dsp_mem.c | 2 1 + 1 - 0 !
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c
> > ===================================================================
> > --- linux-omap-2.6.orig/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:26.000000000 +0100
> > +++ linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:37.000000000 +0100
> > @@ -2052,7 +2052,7 @@ void mbox_fbctl_upd(void)
> > return;
> > }
> > //printk("calling omapfb_update_window_async()\n");
> > - omapfb_update_window_async(registered_fb[1], &win, fbupd_cb, NULL);
> > + omapfb_update_window_async(registered_fb[0], &win, fbupd_cb, NULL);
> > }
> >
> > #else /* CONFIG_FB_OMAP_LCDC_EXTERNAL */
>
> Toshihiro and Hiroshi, can you ack this one?
>
> Regards,
>
> Tony
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dsp: don't use registered_fb[1]
2007-01-28 5:13 ` Hiroshi DOYU
@ 2007-01-31 18:58 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2007-01-31 18:58 UTC (permalink / raw)
To: Hiroshi DOYU; +Cc: linux-omap-open-source
* Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [070127 21:05]:
> Acked.
>
> From: "ext Tony Lindgren" <tony@atomide.com>
> Subject: Re: [PATCH] dsp: don't use registered_fb[1]
> Date: Fri, 26 Jan 2007 13:51:24 -0800
>
> > * Arnaud Patard <arnaud.patard@rtp-net.org> [070114 05:45]:
> > >
> > > According to dsp_fbexport(), the dsp code handles only the first
> > > registered framebuffer, so using registered_fb[1] in mbox_fbctl_upd is
> > > wrong. registered_fb[0] must be used instead.
> > > This code has also the side effect to oops the kernel as
> > > registered_fb[1] is null and omapfb_update_window_async doesn't handle
> > > this case. The fix for omapfb_update_window_async is sent in an other
> > > mail.
> > >
> > >
> > > Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> > > ---
> >
> > > ---
> > > arch/arm/plat-omap/dsp/dsp_mem.c | 2 1 + 1 - 0 !
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Index: linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c
> > > ===================================================================
> > > --- linux-omap-2.6.orig/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:26.000000000 +0100
> > > +++ linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:37.000000000 +0100
> > > @@ -2052,7 +2052,7 @@ void mbox_fbctl_upd(void)
> > > return;
> > > }
> > > //printk("calling omapfb_update_window_async()\n");
> > > - omapfb_update_window_async(registered_fb[1], &win, fbupd_cb, NULL);
> > > + omapfb_update_window_async(registered_fb[0], &win, fbupd_cb, NULL);
> > > }
> > >
> > > #else /* CONFIG_FB_OMAP_LCDC_EXTERNAL */
> >
> > Toshihiro and Hiroshi, can you ack this one?
Pushing today.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-01-31 18:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-14 13:38 [PATCH] dsp: don't use registered_fb[1] Arnaud Patard
2007-01-26 21:51 ` Tony Lindgren
2007-01-28 5:13 ` Hiroshi DOYU
2007-01-31 18:58 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox