Re: [PATCH] dsp: don't use registered_fb[1]

Tony Lindgren
2007-01-26T21:51:24Z

* Arnaud Patard <arnaud.patard@rtp-net.org> [070114 05:45]:
>
> According to dsp_fbexport(), the dsp code handles only the first
> registered framebuffer, so using registered_fb[1] in mbox_fbctl_upd is
> wrong. registered_fb[0] must be used instead.
> This code has also the side effect to oops the kernel as
> registered_fb[1] is null and omapfb_update_window_async doesn't handle
> this case. The fix for omapfb_update_window_async is sent in an other
> mail.
>
>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> ---

> ---
> arch/arm/plat-omap/dsp/dsp_mem.c | 2 1 + 1 - 0 !
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:26.000000000 +0100
> +++ linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:37.000000000 +0100
> @@ -2052,7 +2052,7 @@ void mbox_fbctl_upd(void)
> return;
> }
> //printk("calling omapfb_update_window_async()\n");
> - omapfb_update_window_async(registered_fb[1], &win, fbupd_cb, NULL);
> + omapfb_update_window_async(registered_fb[0], &win, fbupd_cb, NULL);
> }
>
> #else /* CONFIG_FB_OMAP_LCDC_EXTERNAL */

Toshihiro and Hiroshi, can you ack this one?

Regards,

Tony