From: Tony Lindgren <tony@atomide.com>
To: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] gpio-switch.c: use right flags for interrupts
Date: Thu, 1 Feb 2007 10:13:31 -0800 [thread overview]
Message-ID: <20070201181330.GD19495@atomide.com> (raw)
In-Reply-To: <85wt32nqio.fsf@orfeo.duckcorp.org>
* Arnaud Patard <arnaud.patard@rtp-net.org> [070201 02:05]:
>
> Hi,
>
>
> The recent switch from SA_ to IRQF_ constants for interrupt flags
> introduced a typo in the gpio_switch driver (IRQF_SHIRQ doesn't exist
> but IRQF_SHARED does).
>
>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> ---
> ---
> arch/arm/plat-omap/gpio-switch.c | 2 1 + 1 - 0 !
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-omap-2.6/arch/arm/plat-omap/gpio-switch.c
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/plat-omap/gpio-switch.c 2007-02-01 09:40:39.000000000 +0100
> +++ linux-omap-2.6/arch/arm/plat-omap/gpio-switch.c 2007-02-01 09:42:02.000000000 +0100
> @@ -310,7 +310,7 @@ static int __init new_switch(struct gpio
> trigger = IRQF_TRIGGER_RISING;
> }
> r = request_irq(OMAP_GPIO_IRQ(sw->gpio), gpio_sw_irq_handler,
> - IRQF_SHIRQ | trigger, sw->name, sw);
> + IRQF_SHARED | trigger, sw->name, sw);
> if (r < 0) {
> printk(KERN_ERR "gpio-switch: request_irq() failed "
> "for GPIO %d\n", sw->gpio);
Pushing today, also adding to upstream queue.
Regards,
Tony
prev parent reply other threads:[~2007-02-01 18:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-01 10:03 [PATCH] gpio-switch.c: use right flags for interrupts Arnaud Patard
2007-02-01 18:13 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070201181330.GD19495@atomide.com \
--to=tony@atomide.com \
--cc=arnaud.patard@rtp-net.org \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox