From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] gpio-switch.c: use right flags for interrupts Date: Thu, 1 Feb 2007 10:13:31 -0800 Message-ID: <20070201181330.GD19495@atomide.com> References: <85wt32nqio.fsf@orfeo.duckcorp.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <85wt32nqio.fsf@orfeo.duckcorp.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Arnaud Patard Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org * Arnaud Patard [070201 02:05]: > > Hi, > > > The recent switch from SA_ to IRQF_ constants for interrupt flags > introduced a typo in the gpio_switch driver (IRQF_SHIRQ doesn't exist > but IRQF_SHARED does). > > > Signed-off-by: Arnaud Patard > --- > --- > arch/arm/plat-omap/gpio-switch.c | 2 1 + 1 - 0 ! > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-omap-2.6/arch/arm/plat-omap/gpio-switch.c > =================================================================== > --- linux-omap-2.6.orig/arch/arm/plat-omap/gpio-switch.c 2007-02-01 09:40:39.000000000 +0100 > +++ linux-omap-2.6/arch/arm/plat-omap/gpio-switch.c 2007-02-01 09:42:02.000000000 +0100 > @@ -310,7 +310,7 @@ static int __init new_switch(struct gpio > trigger = IRQF_TRIGGER_RISING; > } > r = request_irq(OMAP_GPIO_IRQ(sw->gpio), gpio_sw_irq_handler, > - IRQF_SHIRQ | trigger, sw->name, sw); > + IRQF_SHARED | trigger, sw->name, sw); > if (r < 0) { > printk(KERN_ERR "gpio-switch: request_irq() failed " > "for GPIO %d\n", sw->gpio); Pushing today, also adding to upstream queue. Regards, Tony