[PATCH] gpio-switch.c: use right flags for interrupts

[PATCH] gpio-switch.c: use right flags for interrupts

[Arnaud Patard]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]


Hi,


The recent switch from SA_ to IRQF_ constants for interrupt flags
introduced a typo in the gpio_switch driver (IRQF_SHIRQ doesn't exist
but IRQF_SHARED does).


Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
---

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: irq_changes.patch --]
[-- Type: text/x-diff, Size: 766 bytes --]

---
 arch/arm/plat-omap/gpio-switch.c |    2 	1 +	1 -	0 !
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-omap-2.6/arch/arm/plat-omap/gpio-switch.c
===================================================================
--- linux-omap-2.6.orig/arch/arm/plat-omap/gpio-switch.c	2007-02-01 09:40:39.000000000 +0100
+++ linux-omap-2.6/arch/arm/plat-omap/gpio-switch.c	2007-02-01 09:42:02.000000000 +0100
@@ -310,7 +310,7 @@ static int __init new_switch(struct gpio
 			trigger = IRQF_TRIGGER_RISING;
 	}
 	r = request_irq(OMAP_GPIO_IRQ(sw->gpio), gpio_sw_irq_handler,
-			IRQF_SHIRQ | trigger, sw->name, sw);
+			IRQF_SHARED | trigger, sw->name, sw);
 	if (r < 0) {
 		printk(KERN_ERR "gpio-switch: request_irq() failed "
 		       "for GPIO %d\n", sw->gpio);

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] gpio-switch.c: use right flags for interrupts

[Tony Lindgren]

* Arnaud Patard <arnaud.patard@rtp-net.org> [070201 02:05]:
> 
> Hi,
> 
> 
> The recent switch from SA_ to IRQF_ constants for interrupt flags
> introduced a typo in the gpio_switch driver (IRQF_SHIRQ doesn't exist
> but IRQF_SHARED does).
> 
> 
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> ---

> ---
>  arch/arm/plat-omap/gpio-switch.c |    2 	1 +	1 -	0 !
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-omap-2.6/arch/arm/plat-omap/gpio-switch.c
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/plat-omap/gpio-switch.c	2007-02-01 09:40:39.000000000 +0100
> +++ linux-omap-2.6/arch/arm/plat-omap/gpio-switch.c	2007-02-01 09:42:02.000000000 +0100
> @@ -310,7 +310,7 @@ static int __init new_switch(struct gpio
>  			trigger = IRQF_TRIGGER_RISING;
>  	}
>  	r = request_irq(OMAP_GPIO_IRQ(sw->gpio), gpio_sw_irq_handler,
> -			IRQF_SHIRQ | trigger, sw->name, sw);
> +			IRQF_SHARED | trigger, sw->name, sw);
>  	if (r < 0) {
>  		printk(KERN_ERR "gpio-switch: request_irq() failed "
>  		       "for GPIO %d\n", sw->gpio);

Pushing today, also adding to upstream queue.

Regards,

Tony