From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] add ssi/Kconfig to arch/arm/Kconfig Date: Mon, 5 Mar 2007 02:01:38 -0800 Message-ID: <20070305100136.GC17801@atomide.com> References: <85ps7pgphq.fsf@orfeo.duckcorp.org> <45EAFDBA.9010406@googlemail.com> <85r6s4damj.fsf@orfeo.duckcorp.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <85r6s4damj.fsf@orfeo.duckcorp.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Arnaud Patard Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org * Arnaud Patard [070304 12:25]: > Dirk Behme writes: > > > Arnaud Patard (Rtp) wrote: > >> If one wants to use ssi/Kconfig on arm, it should be added to > >> arch/arm/Kconfig. > > > > Yes, I found this as well by getting > > > > sound/arm/Kconfig:55:warning: 'select' used by config symbol > > 'SND_OMAP_TSC2101' refer to undefined symbol 'OMAP_TSC2101' > > sound/arm/Kconfig:56:warning: 'select' used by config symbol > > 'SND_OMAP_TSC2101' refer to undefined symbol 'OMAP_UWIRE' > > > > Kconfig warnings. > > same here :) > > > > > While touching this, what do you think about doing some more > > clean up: > > > > - omap_uwire.c is now in drivers/spi [], remove (old?) one from > > drivers/ssi > > I had the same patch but you send it before me :) > > > > > - Replace OMAP_UWIRE in Kconfig by SPI_OMAP_UWIRE pointing > > to drivers/spi > > > > ? > > > > Even if I'm not a omap dev, I'll be happy to see the ssi stuff go to > /dev/null. Unfortunately, grep is telling us that there are still users > of the old omap_uwire. Moreover, it seems that it's possible to build a > kernel without the OMAP_UWIRE and with the drivers using it. The drivers > using the old ssi stuff should either depends on it or select it... > (see drivers/video/omap/lcd_{p,h}2.c). > Until this is solved, we won't be able to remove it :( I agree, let's get rid of the old drivers/ssi, anything using it should be updated to use drivers/spi. Regards, Tony