Unable to build any OMAP kernels ?

Unable to build any OMAP kernels ?

[Syed Mohammed, Khasim]

Hello,

I was not able to set default config or compile the kernel (for all
OMAPs). Please see the log below. This is due to the
drivers/video/Kconfig change, if I revert the same it works fine. Am I
doing some thing wrong?  (hope not :)

I will send a patch to correct this one.

LOG:
----
make omap_h3_1710_defconfig
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/basic/docproc
  HOSTCC  scripts/kconfig/conf.o
  HOSTCC  scripts/kconfig/kxgettext.o
  SHIPPED scripts/kconfig/zconf.tab.c
  SHIPPED scripts/kconfig/lex.zconf.c
  SHIPPED scripts/kconfig/zconf.hash.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
file drivers/video/omap/Kconfig already scanned?
make[1]: *** [omap_h3_1710_defconfig] Error 1
make: *** [omap_h3_1710_defconfig] Error 2

PATCH:
------

file:b8f0a11e8f3174c83b02d69229d2d516c251ce4d ->
file:0a99c248bf9639411c40961fbfd86eae90276653
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1635,6 +1635,10 @@ config FB_PS3_DEFAULT_SIZE_M
The default value can be overridden on the kernel command line
using the "ps3fb" option (e.g. "ps3fb=9M");
+if ARCH_OMAP
+ source "drivers/video/omap/Kconfig"
+endif
+

Regards,
Khasim

[PATCH] to revert the drivers/video/Kconfig changes

[Syed Mohammed, Khasim]

To correct the drivers/video/Kconfig (old style).

 Signed off by:
 Syed Mohammed Khasim (x0khasim@ti.com)

===================================================================
--- drivers/video/Kconfig	2007-03-02 17:38:12.000000000 -0600
+++ drivers/video/Kconfig	2007-03-02 17:52:15.000000000 -0600
@@ -1635,10 +1635,6 @@ config FB_PS3_DEFAULT_SIZE_M
 	  The default value can be overridden on the kernel command line
 	  using the "ps3fb" option (e.g. "ps3fb=9M");
 
-if ARCH_OMAP
-	source "drivers/video/omap/Kconfig"
-endif
-
 config FB_VIRTUAL
 	tristate "Virtual Frame Buffer support (ONLY FOR TESTING!)"
 	depends on FB
@@ -1661,9 +1657,7 @@ config FB_VIRTUAL
 
 	  If unsure, say N.
 
-if ARCH_OMAP
-	source "drivers/video/omap/Kconfig"
-endif
+source "drivers/video/omap/Kconfig"
 
 if VT
 	source "drivers/video/console/Kconfig"

Re: [PATCH] to revert the drivers/video/Kconfig changes

[Dirk Behme]

Syed Mohammed, Khasim wrote:
> To correct the drivers/video/Kconfig (old style).
> 
>  Signed off by:
>  Syed Mohammed Khasim (x0khasim@ti.com)

Acked-by: Dirk Behme <dirk.behme@gmail.com>

Re: [PATCH] to revert the drivers/video/Kconfig changes

[Tony Lindgren]

* Dirk Behme <dirk.behme@googlemail.com> [070304 02:09]:
> Syed Mohammed, Khasim wrote:
> >To correct the drivers/video/Kconfig (old style).
> >
> > Signed off by:
> > Syed Mohammed Khasim (x0khasim@ti.com)
> 
> Acked-by: Dirk Behme <dirk.behme@gmail.com>

I've pushed a slightly modified version of this patch to avoid future
merge issues.

Tony

Re: [PATCH] to revert the drivers/video/Kconfig changes

[Tony Lindgren]

* Tony Lindgren <tony@atomide.com> [070305 04:54]:
> * Dirk Behme <dirk.behme@googlemail.com> [070304 02:09]:
> > Syed Mohammed, Khasim wrote:
> > >To correct the drivers/video/Kconfig (old style).
> > >
> > > Signed off by:
> > > Syed Mohammed Khasim (x0khasim@ti.com)
> > 
> > Acked-by: Dirk Behme <dirk.behme@gmail.com>
> 
> I've pushed a slightly modified version of this patch to avoid future
> merge issues.

Correction, will push today at some point.

Tony