RE: [PATCH] Move N800 specific OneNand setup to N800 platform file, was: Basic N800 support

Kyungmin Park
2007-03-08T01:18:32Z

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

Hi

>
> * Dirk Behme <dirk.behme@googlemail.com> [070304 02:11]:
> > Jarkko Lavinen wrote:
> > >>If you don't need async mode settings, it also don't need it.
> > >
> > >Yes. It is obvious. Removed async part. New patch attached.
> >
> > Are there any dependencies to apply this patch I missed? I tried to
> > apply it on top of 01-onenand.patch posted by Tony [1] but got
> > rejects.
> >
> > If not, sligthly modified patch that cleanly applies on top
> of [1] in
> > attachment. I additionally removed duplication of
> omap2_onenand_readw
> > and writew. Can you please test if it is still okay? ;)
>
> I've pushed Jarkko's onenand patches as two parts:
>
> omap-drivers: onenand support for omap2 that can be sent to mtd list

I will push it mtd list

> omap-upstream: onenand board specific support for n800
>
> Can you all please verify that they're OK?

There's one compiler bug related with interrupt handler.

>
> Kyungmin & Dirk, do you have some additional patches on top
> of Jarkko's patches?
>

Please don't patch [1]. If this patch is applied, we have to add all
platform files to add onenand_readw, onenand_writew.

Now apollon board can use it without modification of omap2.c

Thank you,
Kyungmin Park

1. http://linux.omap.com/pipermail/linux-omap-open-source/2007-March/009210.
html

[-- Attachment #2: ARM-OMAP-Fix-old-interrupt-handler-function-in-omap2-onenand.txt --]
[-- Type: text/plain, Size: 984 bytes --]

>From d4978e6cfbb4824391d568051bd0027622cac729 Mon Sep 17 00:00:00 2001
From: Kyungmin Park <kyungmin.park@samsung.com>
Date: Thu, 8 Mar 2007 10:05:01 +0900
Subject: [PATCH] ARM: OMAP: Fix old interrupt handler function in omap2-onenand

Fix old interrupt handler function in omap2-onenand

Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/mtd/onenand/omap2.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index bbc9beb..96fcb5f 100644
--- a/drivers/mtd/onenand/omap2.c
+++ b/drivers/mtd/onenand/omap2.c
@@ -80,8 +80,7 @@ static void omap2_onenand_dma_cb(int lch, u16 ch_status, void *data)
complete(&info->dma_done);
}

-static irqreturn_t omap2_onenand_interrupt(int irq, void *dev_id,
- struct pt_regs *regs)
+static irqreturn_t omap2_onenand_interrupt(int irq, void *dev_id)
{
struct omap2_onenand *info = dev_id;

--
1.4.4.2

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]