Re: TSC2101/2102

[Imre Deak <imre.deak@solidboot.com>]

Hi,

On Thu, Mar 15, 2007 at 10:18:14AM +0900, Kyungmin Park wrote:
> [...] 
>
> In the previous time, I implemented the tsc2101 on OMAP2 based on tsc2301.
> [1]

I needed only the basic register read / write interface to access the
TSC2101 GPIO lines. The TS part you wrote is still needed, it's
init function being called from the tsc2101.c probe, as it's done in
tsc2301-core.c.

> The current code only supports 16-bit tsc2101 for OMAP1.
> We have to consider OMAP2 tsc2101 for H4 and apollon.

Is the 32-bit interface some alternate interface configuration for the chip?
In the TSC2101 spec I found at least only a description of the 16-bit
protocoll. Could you point to a documentation for this?

--Imre

> 
> Here's simple changes.
> 
> +struct tsc2101_platform_data {
> +       int     (*init)(struct spi_device *spi);
> +       void    (*cleanup)(struct spi_device *spi);
> +       void    (*enable_mclk)(struct spi_device *spi);
> +       void    (*disable_mclk)(struct spi_device *spi);
> 
> +       int       bits_per_word;
> 
> +};
> 
> How about to add 'bits_per_word' to platform. So if the bits_per_word is
> empty. it assumes it will use 16-bit, otherwise we use it provided from
> platform.
> 
> +struct tsc2101_device {
> +       struct mutex            mutex;
> +       int                     mclk_enabled;
> +       struct clock            *mclk_ck;
> +       struct spi_message      message;
> +       struct spi_transfer     transfer[2];
> +       u16                     command;
> +       void                    (*enable_mclk)(struct spi_device *spi);
> +       void                    (*disable_mclk)(struct spi_device *spi);
> 
> +       int		32bit_shift;	/* 16 if 32-bit bus, otherwise 0 */
> 
> +};
> 
> Please change the command from u16 to u32. Umm, I'm not sure we have to
> change the parameter from u16 *data to u32 *data.
> 
> I will check it.
> 
> Thank you,
> Kyungmin Park
> 
> 1. http://linux.omap.com/pipermail/linux-omap-open-source/2007-
> January/008933.html
>