public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Syed Mohammed, Khasim" <x0khasim@ti.com>
Cc: linux-omap-open-source@linux.omap.com, kmpark@infradead.org
Subject: Re: [PATCH] ARM: OMAP: MMC performance upgrade on OMAP2
Date: Thu, 29 Mar 2007 16:13:18 -0400	[thread overview]
Message-ID: <20070329201316.GG3638@atomide.com> (raw)
In-Reply-To: <9C23CDD79DA20A479D4615857B2E2C476F2884@dlee13.ent.ti.com>

Hi,

* Syed Mohammed, Khasim <x0khasim@ti.com> [070308 23:38]:
> Hi Kyungmin,
> 
> For OMAP2420 there are few MMC erratas,
> 
> 1. If MMC controller is configured for 4bit and if MMC CLK frequency is
> over 24Mhz it has as a diminishing impact on throughput. Hence, it is
> not recommended to use a clock over 24MHz for MMC 4 bits mode.

> >@@ -1096,7 +1098,10 @@ static int __init mmc_omap_probe(struct
> >platform_device *pdev)
> >
> > 	mmc->ops = &mmc_omap_ops;
> > 	mmc->f_min = 400000;
> >-	mmc->f_max = 24000000;
> >+	if (cpu_class_is_omap2())
> >+		mmc->f_max = 48000000;
> >+	else
> >+		mmc->f_max = 24000000;
> > 	mmc->ocr_avail = MMC_VDD_32_33 | MMC_VDD_33_34;
> > 	mmc->caps = MMC_CAP_MULTIWRITE | MMC_CAP_BYTEBLOCK;

How about throwing a cpu_is_omap2420() in there to work around the
clock limitation above mentioned by Khasim?

Tony

  reply	other threads:[~2007-03-29 20:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-07  7:44 [PATCH] ARM: OMAP: MMC performance upgrade on OMAP2 Kyungmin Park
2007-03-08  6:06 ` Kyungmin Park
     [not found]   ` <45EFA96D.9010604@drzeus.cx>
2007-03-08  7:28     ` Kyungmin Park
2007-03-08 12:02       ` Syed Mohammed, Khasim
     [not found]         ` <45F00C93.2000305@drzeus.cx>
2007-03-08 13:16           ` Syed Mohammed, Khasim
2007-03-09  2:41         ` Kyungmin Park
2007-03-09  5:10           ` Syed Mohammed, Khasim
2007-03-09  5:18             ` Syed Mohammed, Khasim
2007-03-09  5:59               ` Kyungmin Park
2007-03-09  6:16                 ` Syed Mohammed, Khasim
2007-03-09  3:31 ` Syed Mohammed, Khasim
2007-03-29 20:13   ` Tony Lindgren [this message]
     [not found] <45F0FC9F.3070701@drzeus.cx>
2007-03-09  6:40 ` Syed Mohammed, Khasim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070329201316.GG3638@atomide.com \
    --to=tony@atomide.com \
    --cc=kmpark@infradead.org \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=x0khasim@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox