public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula@nokia.com>
To: ext Tony Lindgren <tony@atomide.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH 4/4] ARM: OMAP: Update TSC2301 touchscreen config name in board-n800.c
Date: Mon, 2 Apr 2007 10:05:11 +0300	[thread overview]
Message-ID: <20070402100511.7f18c104.jarkko.nikula@nokia.com> (raw)
In-Reply-To: <20070330191344.GJ18375@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

On Fri, 30 Mar 2007 15:13:46 -0400
"ext Tony Lindgren" <tony@atomide.com> wrote:

> * Jarkko Nikula <jarkko.nikula@nokia.com> [070322 05:17]:
> > Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
> > ---
> >  arch/arm/mach-omap2/board-n800.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> This is already applied now too.
> 
Not correctly :-)

It seems that you took "commit
64e78a98859a4ce028121a6b5d462b504f9b9343" from my first patchset
changing also TSC2301-mixer config name which was not required for
latter set.

This could be corrected by either reverting whole
64e78a98859a4ce028121a6b5d462b504f9b9343 and applying only this one:

http://linux.omap.com/pipermail/linux-omap-open-source/2007-March/009402.html

or by applying audio config name revert patch I'm attaching here.


-- 
Jarkko

[-- Attachment #2: 0001-ARM-OMAP-Revert-TSC2301-audio-config-name-change-in-board-n800-audio.c.txt --]
[-- Type: text/plain, Size: 1059 bytes --]

>From 5ce8f5744d8ec067389a67f83adb53545f95e0ad Mon Sep 17 00:00:00 2001
From: Jarkko Nikula <jarkko.nikula@nokia.com>
Date: Mon, 2 Apr 2007 09:59:38 +0300
Subject: [PATCH] ARM: OMAP: Revert TSC2301 audio config name change in board-n800-audio.c

Commit 64e78a98859a4ce028121a6b5d462b504f9b9343 was accidentally took
from older patchset where with the newer set TSC2301 audio config name
didn't change.

Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
---
 arch/arm/mach-omap2/board-n800-audio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-n800-audio.c b/arch/arm/mach-omap2/board-n800-audio.c
index 6bdf1c8..fa6ab86 100644
--- a/arch/arm/mach-omap2/board-n800-audio.c
+++ b/arch/arm/mach-omap2/board-n800-audio.c
@@ -31,7 +31,7 @@
 
 #include "../plat-omap/dsp/dsp_common.h"
 
-#if defined(CONFIG_SND_SOC_TSC2301) && defined(CONFIG_SND_OMAP24XX_EAC)
+#if defined(CONFIG_SPI_TSC2301_AUDIO) && defined(CONFIG_SND_OMAP24XX_EAC)
 #define AUDIO_ENABLED
 
 static struct clk *sys_clkout2;
-- 
1.4.4.4


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2007-04-02  7:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-22  9:15 [PATCH 4/4] ARM: OMAP: Update TSC2301 touchscreen config name in board-n800.c Jarkko Nikula
2007-03-30 19:13 ` Tony Lindgren
2007-04-02  7:05   ` Jarkko Nikula [this message]
2007-04-03 19:46     ` tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070402100511.7f18c104.jarkko.nikula@nokia.com \
    --to=jarkko.nikula@nokia.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox