Re: [PATCH] serial: Add driver for OMAP UARTs

Juha Yrjola
2007-04-10T10:07:24Z

Hi Khasim,

Syed Mohammed, Khasim wrote:

> One concern I had here was, as we know OMAP supports multiple (3)
> UART ports and they can be used for IrDA (UART3), Bluetooth (UART2/1),
> Serial applications etc. All these drivers should configure/use
> similar register sets. So if we could,
>
> - make the arch/arm/mach-omap2/serial.c more kind of a generic UART
> API library that can be used by all UART drivers.
> - the UART library should handle overall clock /power management policy.
> - Centralized interrupt handler.
> - DMA / Polling / Interrupt based read/writes.

It is certainly a good idea. You probably meant to write
plat-omap/serial.c, since obviously the implementation shouldn't be
limited to OMAP2.

I suppose the UART library will not be trivial, though. I don't know
what kind of special needs Bluetooth and IrDA have, but for example the
serial console code needs specific handling for the Magic SysRQ
characters in the RX loop. The N800 Bluetooth driver does some funky
stuff related to PM, as well.

Cheers,
Juha