Re: [PATCH] serial: Add driver for OMAP UARTs

Tony Lindgren
2007-04-17T20:06:40Z

* George G. Davis <gdavis@mvista.com> [070412 13:42]:
> On Mon, Apr 09, 2007 at 11:44:33PM +0300, Juha Yrjölä wrote:
> > +static struct uart_driver serial_omap_reg = {
> > + .owner = THIS_MODULE,
> > + .driver_name = "OMAP serial",
>
> You may want to reconsider ".driver_name" otherwise I suspect this may
> appear as:
>
> "/proc/tty/driver/OMAP serial"
>
> Yuck. : )
>
> > + .dev_name = "ttyS",
> > + .major = TTY_MAJOR,
> > + .minor = 64,
> > + .nr = 3,
> > + .cons = OMAP_CONSOLE,
> > +};

Also one thing that needs to be verified is that using ttyS may
conflict with standard 8250 add-on ports, such as CF/PCMCIA modems
or bluetooth devices. At least it used to be that the non 8250 serial
ports must use a different name because of this issue.

Regards,

Tony