From: Tony Lindgren <tony@atomide.com>
To: "George G. Davis" <gdavis@mvista.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] serial: Add driver for OMAP UARTs
Date: Tue, 17 Apr 2007 20:06:40 +0000 [thread overview]
Message-ID: <20070417200639.GG26287@atomide.com> (raw)
In-Reply-To: <20070412133710.GA9104@mvista.com>
* George G. Davis <gdavis@mvista.com> [070412 13:42]:
> On Mon, Apr 09, 2007 at 11:44:33PM +0300, Juha Yrjölä wrote:
> > +static struct uart_driver serial_omap_reg = {
> > + .owner = THIS_MODULE,
> > + .driver_name = "OMAP serial",
>
> You may want to reconsider ".driver_name" otherwise I suspect this may
> appear as:
>
> "/proc/tty/driver/OMAP serial"
>
> Yuck. : )
>
> > + .dev_name = "ttyS",
> > + .major = TTY_MAJOR,
> > + .minor = 64,
> > + .nr = 3,
> > + .cons = OMAP_CONSOLE,
> > +};
Also one thing that needs to be verified is that using ttyS may
conflict with standard 8250 add-on ports, such as CF/PCMCIA modems
or bluetooth devices. At least it used to be that the non 8250 serial
ports must use a different name because of this issue.
Regards,
Tony
prev parent reply other threads:[~2007-04-17 20:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-09 20:44 [PATCH] serial: Add driver for OMAP UARTs Juha Yrjölä
2007-04-10 5:36 ` Syed Mohammed, Khasim
2007-04-10 10:07 ` Juha Yrjola
2007-04-10 12:28 ` Ville Tervo
2007-04-12 13:37 ` George G. Davis
2007-04-12 14:23 ` Testing SPI on omap5912 Raja Mallik
2007-04-17 20:06 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070417200639.GG26287@atomide.com \
--to=tony@atomide.com \
--cc=gdavis@mvista.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox