Re: [RFC/PATCH] ARM: OMAP: OneNAND support for 2430SDP

Tony Lindgren
2007-05-02T17:45:27Z

* Kevin Hilman <khilman@mvista.com> [070430 22:39]:
> On Thu, 2007-04-26 at 17:35 +0000, Tony Lindgren wrote:
> > * Kevin Hilman <khilman@mvista.com> [070321 00:49]:
> > > Adds platform device for use of existing OMAP2 driver. Also, the
> > > following changes are made to the existing driver:
> > >
> > > - add option for not using DMA (by passing dma_channel = -1)
> > > - removes obsoleted pt_regs arg from interrupt handler
> > >
> > > RFC: Notice the change to onenand_base.c which comments out the last
> > > OOB chunk. Without this, it would not work. Previous drivers
> > > for this board such as the 2.6.10-based MV kernel have this
> > > same change. Anyone know what is going on here?
> >
> > Can you please refresh this one and split it into two patches:
> >
> > > arch/arm/mach-omap2/Makefile | 3
> > > arch/arm/mach-omap2/board-2430sdp-flash.c | 108 ++++++++++++++++++++++++++++++
> > > arch/arm/mach-omap2/board-2430sdp.c | 4 +
> > > arch/arm/mach-omap2/gpmc.c | 1
> > > include/asm-arm/arch-omap/gpmc.h | 7 +
> > > include/asm-arm/arch-omap/onenand.h | 1
> >
> > The above could be one patch ready for omap-upstream queue.
> >
> > > drivers/mtd/onenand/omap2.c | 103 +++++++++++++++++-----------
> > > drivers/mtd/onenand/onenand_base.c | 2
> >
> > This should be separate and sent to MTD list.
>
> Kyungmin,
>
> What's the status of the patch you submitted to the MTD list for this
> fix?
>
> FWIW, attached is a patch which fixes the walking of the ooblist, as
> well as an update to the omap2 driver for the non-DMA case.

The attached patch did not seem to make it to the mailing list.

Tony