RE: [RFC/PATCH] ARM: OMAP: OneNAND support for 2430SDP

Jalori, Mohit
2007-03-21T19:15:54Z

> -----Original Message-----
> From: linux-omap-open-source-bounces@linux.omap.com
[mailto:linux-omap-
> open-source-bounces@linux.omap.com] On Behalf Of Kevin Hilman
> Sent: Tuesday, March 20, 2007 7:41 PM
> To: linux-omap-open-source@linux.omap.com
> Subject: [RFC/PATCH] ARM: OMAP: OneNAND support for 2430SDP
>
> Adds platform device for use of existing OMAP2 driver. Also, the
> following changes are made to the existing driver:
>
> - add option for not using DMA (by passing dma_channel = -1)
> - removes obsoleted pt_regs arg from interrupt handler
>
> RFC: Notice the change to onenand_base.c which comments out the last
> OOB chunk. Without this, it would not work. Previous drivers
> for this board such as the 2.6.10-based MV kernel have this
> same change. Anyone know what is going on here?
>

We got this change from MV in the patch he sent to fix an issue we were
seeing with mounting an empty jffs2 partition. Here are the comments
that came in with it

" The oobfree list in the MTD OneNAND driver is of length 8. This
exceeds the maximum length of 7, because the eighth entry must be used
as a null terminator. The absence of a terminator causes a variety of
problems in various places (especially JFFS2 and YAFFS2) where the
oobfree list is scanned. The fix is to do without the eighth entry.

This fix is only of local interest because the handling of oobinfo has
been completely redesigned as of 2.6.17-rc6. "

>From the last line we should not need this for later kernel versions.

Regards
Mohit