public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH / RFC] Formating changes for Basic OMAP2430 High speed I2C
@ 2007-04-24  0:49 Syed Mohammed, Khasim
  2007-04-26 18:13 ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Syed Mohammed, Khasim @ 2007-04-24  0:49 UTC (permalink / raw)
  To: linux-omap-open-source

Resubmitting after incorporating review comments

This patch contains the formatting changes.

Signed-off-by: Syed Mohammed Khasim  <x0khasim@ti.com>

Files:
 drivers/i2c/busses/i2c-omap.c
=============================================================================
--- linux-omap/drivers/i2c/busses/i2c-omap.c	2007-01-08 18:56:31.000000000 -0600
+++ lin_for_hsi2c/drivers/i2c/busses/i2c-omap.c	2007-04-23 19:04:50.000000000 -0500
@@ -2,14 +2,16 @@
  * TI OMAP I2C master mode driver
  *
  * Copyright (C) 2003 MontaVista Software, Inc.
- * Copyright (C) 2004 Texas Instruments.
- *
- * Updated to work with multiple I2C interfaces on 24xx by
- * Tony Lindgren <tony@atomide.com> and Imre Deak <imre.deak@nokia.com>
  * Copyright (C) 2005 Nokia Corporation
+ * Copyright (C) 2004 - 2007 Texas Instruments.
  *
- * Cleaned up by Juha Yrjölä <juha.yrjola@nokia.com>
- *
+ * Originally written by MontaVista Software, Inc.
+ * Additional contributions by:
+ *	Tony Lindgren <tony@atomide.com>
+ *	Imre Deak <imre.deak@nokia.com>
+ *	Juha Yrjölä <juha.yrjola@nokia.com>
+ *	Syed Khasim <x0khasim@ti.com>
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
@@ -257,9 +259,9 @@ static int omap_i2c_init(struct omap_i2c
 
 	/* Enable interrupts */
 	omap_i2c_write_reg(dev, OMAP_I2C_IE_REG,
-			   (OMAP_I2C_IE_XRDY | OMAP_I2C_IE_RRDY |
-			    OMAP_I2C_IE_ARDY | OMAP_I2C_IE_NACK |
-			    OMAP_I2C_IE_AL));
+			(OMAP_I2C_IE_XRDY | OMAP_I2C_IE_RRDY |
+			OMAP_I2C_IE_ARDY | OMAP_I2C_IE_NACK |
+			OMAP_I2C_IE_AL));
 	return 0;
 }
 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH / RFC] Formating changes for Basic OMAP2430 High speed I2C
  2007-04-24  0:49 [PATCH / RFC] Formating changes for Basic OMAP2430 High speed I2C Syed Mohammed, Khasim
@ 2007-04-26 18:13 ` Tony Lindgren
  2007-04-26 22:52   ` Syed Mohammed, Khasim
  0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2007-04-26 18:13 UTC (permalink / raw)
  To: Syed Mohammed, Khasim; +Cc: linux-omap-open-source

* Syed Mohammed, Khasim <x0khasim@ti.com> [070424 00:50]:
> Resubmitting after incorporating review comments
> 
> This patch contains the formatting changes.

Pushing today.

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH / RFC] Formating changes for Basic OMAP2430 High speed I2C
  2007-04-26 18:13 ` Tony Lindgren
@ 2007-04-26 22:52   ` Syed Mohammed, Khasim
  2007-04-26 23:30     ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Syed Mohammed, Khasim @ 2007-04-26 22:52 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: linux-omap-open-source

Hi Tony,

I might have to resubmit the TWL Keypad driver. But the TWL GPIO driver can go in. 

I didn't see any comments for these, can you please review the TWL Keypad and TWL GPIO patch set? I will incorporate the review comments (if any) and post them once. 

Thanks & Regards,
Khasim

>-----Original Message-----
>From: Tony Lindgren [mailto:tony@atomide.com]
>Sent: Thursday, April 26, 2007 1:14 PM
>To: Syed Mohammed, Khasim
>Cc: linux-omap-open-source@linux.omap.com
>Subject: Re: [PATCH / RFC] Formating changes for Basic OMAP2430 High speed
>I2C
>
>* Syed Mohammed, Khasim <x0khasim@ti.com> [070424 00:50]:
>> Resubmitting after incorporating review comments
>>
>> This patch contains the formatting changes.
>
>Pushing today.
>
>Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH / RFC] Formating changes for Basic OMAP2430 High speed I2C
  2007-04-26 22:52   ` Syed Mohammed, Khasim
@ 2007-04-26 23:30     ` Tony Lindgren
  0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2007-04-26 23:30 UTC (permalink / raw)
  To: Syed Mohammed, Khasim; +Cc: linux-omap-open-source

* Syed Mohammed, Khasim <x0khasim@ti.com> [070426 22:52]:
> Hi Tony,
> 
> I might have to resubmit the TWL Keypad driver. But the TWL GPIO driver can go in. 
> 
> I didn't see any comments for these, can you please review the TWL Keypad and TWL GPIO patch set? I will incorporate the review comments (if any) and post them once. 

In general they look OK. But I thought you already figured out a way
to make email not wrap patches! :) They're both wrapped, can you
please repost one more time unwrapped?

Regards,

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-04-26 23:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-24  0:49 [PATCH / RFC] Formating changes for Basic OMAP2430 High speed I2C Syed Mohammed, Khasim
2007-04-26 18:13 ` Tony Lindgren
2007-04-26 22:52   ` Syed Mohammed, Khasim
2007-04-26 23:30     ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox