* [PATCH] omap2_get_clksel(): fix suspicious assignment
@ 2007-05-02 14:46 Paul Walmsley
2007-05-02 15:53 ` Woodruff, Richard
0 siblings, 1 reply; 3+ messages in thread
From: Paul Walmsley @ 2007-05-02 14:46 UTC (permalink / raw)
To: linux-omap-open-source
mach-omap2/clock.c contains a suspicious assignment that
almost certainly should be a equality test, in omap2_get_clksel().
Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
arch/arm/mach-omap2/clock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-omap-2.6/arch/arm/mach-omap2/clock.c
===================================================================
--- linux-omap-2.6.orig/arch/arm/mach-omap2/clock.c
+++ linux-omap-2.6/arch/arm/mach-omap2/clock.c
@@ -651,7 +651,7 @@ static u32 omap2_get_clksel(u32 *div_sel
break;
case CM_SYSCLKOUT_SEL1:
div_addr = (u32)&PRCM_CLKOUT_CTRL;
- if ((div_off == 3) || (div_off = 11))
+ if ((div_off == 3) || (div_off == 11))
mask= 0x3;
break;
case CM_CORE_SEL1:
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] omap2_get_clksel(): fix suspicious assignment
2007-05-02 14:46 [PATCH] omap2_get_clksel(): fix suspicious assignment Paul Walmsley
@ 2007-05-02 15:53 ` Woodruff, Richard
2007-05-02 17:33 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Woodruff, Richard @ 2007-05-02 15:53 UTC (permalink / raw)
To: Paul Walmsley, linux-omap-open-source
> mach-omap2/clock.c contains a suspicious assignment that
> almost certainly should be a equality test, in omap2_get_clksel().
Yes, its obviously wrong. Nice to fix.
Strangely, my pre-translated trees are correct for this. Generally,
I've tried to keep this aspect in bug fix sync.
Regards,
Richard W.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] omap2_get_clksel(): fix suspicious assignment
2007-05-02 15:53 ` Woodruff, Richard
@ 2007-05-02 17:33 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2007-05-02 17:33 UTC (permalink / raw)
To: Woodruff, Richard; +Cc: Paul Walmsley, linux-omap-open-source
* Woodruff, Richard <r-woodruff2@ti.com> [070502 15:57]:
> > mach-omap2/clock.c contains a suspicious assignment that
> > almost certainly should be a equality test, in omap2_get_clksel().
>
> Yes, its obviously wrong. Nice to fix.
>
> Strangely, my pre-translated trees are correct for this. Generally,
> I've tried to keep this aspect in bug fix sync.
Thanks, pushing today.
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-05-02 17:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-02 14:46 [PATCH] omap2_get_clksel(): fix suspicious assignment Paul Walmsley
2007-05-02 15:53 ` Woodruff, Richard
2007-05-02 17:33 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox