From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@mvista.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [RFC/PATCH] ARM: OMAP: OneNAND support for 2430SDP
Date: Wed, 2 May 2007 17:45:27 +0000 [thread overview]
Message-ID: <20070502174526.GH3520@atomide.com> (raw)
In-Reply-To: <1177972442.32350.9.camel@paris.hilman.org>
* Kevin Hilman <khilman@mvista.com> [070430 22:39]:
> On Thu, 2007-04-26 at 17:35 +0000, Tony Lindgren wrote:
> > * Kevin Hilman <khilman@mvista.com> [070321 00:49]:
> > > Adds platform device for use of existing OMAP2 driver. Also, the
> > > following changes are made to the existing driver:
> > >
> > > - add option for not using DMA (by passing dma_channel = -1)
> > > - removes obsoleted pt_regs arg from interrupt handler
> > >
> > > RFC: Notice the change to onenand_base.c which comments out the last
> > > OOB chunk. Without this, it would not work. Previous drivers
> > > for this board such as the 2.6.10-based MV kernel have this
> > > same change. Anyone know what is going on here?
> >
> > Can you please refresh this one and split it into two patches:
> >
> > > arch/arm/mach-omap2/Makefile | 3
> > > arch/arm/mach-omap2/board-2430sdp-flash.c | 108 ++++++++++++++++++++++++++++++
> > > arch/arm/mach-omap2/board-2430sdp.c | 4 +
> > > arch/arm/mach-omap2/gpmc.c | 1
> > > include/asm-arm/arch-omap/gpmc.h | 7 +
> > > include/asm-arm/arch-omap/onenand.h | 1
> >
> > The above could be one patch ready for omap-upstream queue.
> >
> > > drivers/mtd/onenand/omap2.c | 103 +++++++++++++++++-----------
> > > drivers/mtd/onenand/onenand_base.c | 2
> >
> > This should be separate and sent to MTD list.
>
> Kyungmin,
>
> What's the status of the patch you submitted to the MTD list for this
> fix?
>
> FWIW, attached is a patch which fixes the walking of the ooblist, as
> well as an update to the omap2 driver for the non-DMA case.
The attached patch did not seem to make it to the mailing list.
Tony
prev parent reply other threads:[~2007-05-02 17:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 0:40 [RFC/PATCH] ARM: OMAP: OneNAND support for 2430SDP Kevin Hilman
2007-03-21 19:15 ` Jalori, Mohit
2007-03-21 19:50 ` Kevin Hilman
2007-03-22 1:06 ` Kyungmin Park
2007-03-22 3:14 ` Kevin Hilman
2007-03-22 4:50 ` Kyungmin Park
2007-03-22 5:02 ` Kyungmin Park
2007-03-22 16:53 ` Kevin Hilman
2007-03-23 4:40 ` Kyungmin Park
2007-04-26 17:35 ` Tony Lindgren
2007-04-30 22:34 ` Kevin Hilman
2007-05-02 17:45 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070502174526.GH3520@atomide.com \
--to=tony@atomide.com \
--cc=khilman@mvista.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox