Last call for bug fixes before 2.6.21-omap1 will be tagged

Last call for bug fixes before 2.6.21-omap1 will be tagged

[Tony Lindgren]

Hi all,

I'm planning to tag 2.6.21-omap1 on Friday so let's make sure most of
the boards run fine. If you have any pending bug fixes for 2.6.21,
now it's time to send them.

Regards,

Tony

Re: Last call for bug fixes before 2.6.21-omap1 will be tagged

[Trilok Soni]

On 5/2/07, Tony Lindgren <tony@atomide.com> wrote:
> Hi all,
>
> I'm planning to tag 2.6.21-omap1 on Friday so let's make sure most of
> the boards run fine. If you have any pending bug fixes for 2.6.21,
> now it's time to send them.
>

OMAP2430 defconfig build failure for USB.

-------------------------snip----------------------------
In file included from drivers/usb/musb/plat_uds.c:109:
drivers/usb/musb/musbdefs.h:67:31: error: asm/arch/hdrc_cnf.h: No such
file or directory
drivers/usb/musb/plat_uds.c: In function 'fifo_setup':
drivers/usb/musb/plat_uds.c:944: error: 'MUSB_C_RAM_BITS' undeclared
(first use in this function)
drivers/usb/musb/plat_uds.c:944: error: (Each undeclared identifier is
reported only once
drivers/usb/musb/plat_uds.c:944: error: for each function it appears in.)
drivers/usb/musb/plat_uds.c: In function 'ep_config_from_table':
drivers/usb/musb/plat_uds.c:1068: error: 'MUSB_C_RAM_BITS' undeclared
(first use in this function)
make[2]: *** [drivers/usb/musb/plat_uds.o] Error 1
make[1]: *** [drivers/usb/musb] Error 2
-------------------------snip----------------------------

-- 
--Trilok Soni

Re: Last call for bug fixes before 2.6.21-omap1 will be tagged

[Kevin Hilman]

On Thu, 2007-05-03 at 15:28 +0530, Trilok Soni wrote:
> On 5/2/07, Tony Lindgren <tony@atomide.com> wrote:
> > Hi all,
> >
> > I'm planning to tag 2.6.21-omap1 on Friday so let's make sure most of
> > the boards run fine. If you have any pending bug fixes for 2.6.21,
> > now it's time to send them.
> >
> 
> OMAP2430 defconfig build failure for USB.
> 

MUSB should not be enabled in the .config.

MUSB support is not quite ready for the 2430 yet.  I have gadget working
locally, but have some problems with host mode.  Will post patches when
I have it working.

Kevin

Re: Last call for bug fixes before 2.6.21-omap1 will be tagged

[Tony Lindgren]

* Kevin Hilman <khilman@mvista.com> [070503 13:35]:
> On Thu, 2007-05-03 at 15:28 +0530, Trilok Soni wrote:
> > On 5/2/07, Tony Lindgren <tony@atomide.com> wrote:
> > > Hi all,
> > >
> > > I'm planning to tag 2.6.21-omap1 on Friday so let's make sure most of
> > > the boards run fine. If you have any pending bug fixes for 2.6.21,
> > > now it's time to send them.
> > >
> > 
> > OMAP2430 defconfig build failure for USB.
> > 
> 
> MUSB should not be enabled in the .config.
> 
> MUSB support is not quite ready for the 2430 yet.  I have gadget working
> locally, but have some problems with host mode.  Will post patches when
> I have it working.

I just posted 7 musb/tusb6010 patches to this list that may help.
Patch "Avoid host babble by checking tx fifo" in the series should fix lots
of musb host side issues.

Regards,

Tony

[PATCH 1/1] ARM: OMAP2: Remove redundant check on osc refcount

[Igor Stoppa]

The usage of the external oscillator is handled already by
sleep_block and doesn't require any extra checking.
Incidentally this fixes a bug where N800 wouldn't enter retention
the first time the display would blank.

Signed-off-by: Klaus Pedersen <klaus.k.pedersen@nokia.com>

Signed-off-by: Igor Stoppa <igor.stoppa@nokia.com>
---
 arch/arm/mach-omap2/pm.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
index b3a0d9d..63e380f 100644
--- a/arch/arm/mach-omap2/pm.c
+++ b/arch/arm/mach-omap2/pm.c
@@ -621,8 +621,6 @@ static int omap2_can_sleep(void)
 		return 0;
 	if (atomic_read(&sleep_block) > 0)
 		return 0;
-	if (clk_get_usecount(osc_ck) > 1)
-		return 0;
 	if (omap_dma_running())
 		return 0;
 
-- 
1.5.1.3

Re: [PATCH 1/1] ARM: OMAP2: Remove redundant check on osc refcount

[Tony Lindgren]

* Igor Stoppa <igor.stoppa@nokia.com> [070504 06:21]:
> The usage of the external oscillator is handled already by
> sleep_block and doesn't require any extra checking.
> Incidentally this fixes a bug where N800 wouldn't enter retention
> the first time the display would blank.
> 
> Signed-off-by: Klaus Pedersen <klaus.k.pedersen@nokia.com>
> 
> Signed-off-by: Igor Stoppa <igor.stoppa@nokia.com>
> ---
>  arch/arm/mach-omap2/pm.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
> index b3a0d9d..63e380f 100644
> --- a/arch/arm/mach-omap2/pm.c
> +++ b/arch/arm/mach-omap2/pm.c
> @@ -621,8 +621,6 @@ static int omap2_can_sleep(void)
>  		return 0;
>  	if (atomic_read(&sleep_block) > 0)
>  		return 0;
> -	if (clk_get_usecount(osc_ck) > 1)
> -		return 0;
>  	if (omap_dma_running())
>  		return 0;
>  

Thanks, pushing today.

Tony