public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* ARM: OMAP: Select GENERIC_CLOCKEVENTS patch
@ 2007-05-08  7:07 Trilok Soni
  2007-05-08 21:01 ` Kevin Hilman
  0 siblings, 1 reply; 3+ messages in thread
From: Trilok Soni @ 2007-05-08  7:07 UTC (permalink / raw)
  To: linux-omap-open-source

Tony,

"select GENERIC_CLOCKEVENTS" patch makes H4 build with default MPU
timer selected to fail because timer_tick() is only available if
CLOCKEVENTS is not defined.

Do we really need to select GENERIC_CLOCKEVENTS by default? Other
solution is then to add !GENERIC_CLOCKEVENT as dependency in MPU_TIMER
KConfig.

-- 
--Trilok Soni

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: ARM: OMAP: Select GENERIC_CLOCKEVENTS patch
  2007-05-08  7:07 ARM: OMAP: Select GENERIC_CLOCKEVENTS patch Trilok Soni
@ 2007-05-08 21:01 ` Kevin Hilman
  2007-05-08 21:07   ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2007-05-08 21:01 UTC (permalink / raw)
  To: Trilok Soni; +Cc: linux-omap-open-source

On Tue, 2007-05-08 at 12:37 +0530, Trilok Soni wrote:

> "select GENERIC_CLOCKEVENTS" patch makes H4 build with default MPU
> timer selected to fail because timer_tick() is only available if
> CLOCKEVENTS is not defined.
> 
> Do we really need to select GENERIC_CLOCKEVENTS by default? Other
> solution is then to add !GENERIC_CLOCKEVENT as dependency in MPU_TIMER
> KConfig.

GENERIC_CLOCKEVENTS is not quite ready for OMAP2.  I will have it ready
in a week or so.  In the mean time, this patch will only enable
GENERIC_CLOCKEVENTS for OMAP1.

Signed-off-by: Kevin Hilman <khilman@mvista.com>

Index: dev/arch/arm/Kconfig
===================================================================
--- dev.orig/arch/arm/Kconfig
+++ dev/arch/arm/Kconfig
@@ -380,7 +380,6 @@ config ARCH_OMAP
 	bool "TI OMAP"
 	select GENERIC_GPIO
 	select GENERIC_TIME
-	select GENERIC_CLOCKEVENTS
 	help
 	  Support for TI's OMAP platform (OMAP1 and OMAP2).
 
Index: dev/arch/arm/plat-omap/Kconfig
===================================================================
--- dev.orig/arch/arm/plat-omap/Kconfig
+++ dev/arch/arm/plat-omap/Kconfig
@@ -11,6 +11,7 @@ choice
 
 config ARCH_OMAP1
 	bool "TI OMAP1"
+	select GENERIC_CLOCKEVENTS
 
 config ARCH_OMAP2
 	bool "TI OMAP2"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: ARM: OMAP: Select GENERIC_CLOCKEVENTS patch
  2007-05-08 21:01 ` Kevin Hilman
@ 2007-05-08 21:07   ` Tony Lindgren
  0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2007-05-08 21:07 UTC (permalink / raw)
  To: Kevin Hilman; +Cc: linux-omap-open-source

* Kevin Hilman <khilman@mvista.com> [070508 14:02]:
> On Tue, 2007-05-08 at 12:37 +0530, Trilok Soni wrote:
> 
> > "select GENERIC_CLOCKEVENTS" patch makes H4 build with default MPU
> > timer selected to fail because timer_tick() is only available if
> > CLOCKEVENTS is not defined.
> > 
> > Do we really need to select GENERIC_CLOCKEVENTS by default? Other
> > solution is then to add !GENERIC_CLOCKEVENT as dependency in MPU_TIMER
> > KConfig.
> 
> GENERIC_CLOCKEVENTS is not quite ready for OMAP2.  I will have it ready
> in a week or so.  In the mean time, this patch will only enable
> GENERIC_CLOCKEVENTS for OMAP1.

OK, thanks, will push today.

Tony

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-05-08 21:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-08  7:07 ARM: OMAP: Select GENERIC_CLOCKEVENTS patch Trilok Soni
2007-05-08 21:01 ` Kevin Hilman
2007-05-08 21:07   ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox