From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] fix sti-netlink.c compilation failure
Date: Tue, 8 May 2007 14:39:39 -0700 [thread overview]
Message-ID: <20070508213939.GL32547@atomide.com> (raw)
In-Reply-To: <20070508200138.420874830@pwsan.com>
* Paul Walmsley <paul@pwsan.com> [070508 13:04]:
> Fix this compilation error in current linux-omap-2.6 git head:
>
> CC arch/arm/plat-omap/sti/sti-netlink.o
> arch/arm/plat-omap/sti/sti-netlink.c: In function 'sti_netlink_init':
> arch/arm/plat-omap/sti/sti-netlink.c:145: warning: passing argument 4 of 'netlink_kernel_create' from incompatible pointer type
> arch/arm/plat-omap/sti/sti-netlink.c:145: error: too few arguments to function 'netlink_kernel_create'
> make[2]: *** [arch/arm/plat-omap/sti/sti-netlink.o] Error 1
> make[1]: *** [arch/arm/plat-omap/sti] Error 2
> make: *** [arch/arm/plat-omap] Error 2
>
> Compile-tested only.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
>
> ---
> arch/arm/plat-omap/sti/sti-netlink.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-omap-2.6/arch/arm/plat-omap/sti/sti-netlink.c
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/plat-omap/sti/sti-netlink.c
> +++ linux-omap-2.6/arch/arm/plat-omap/sti/sti-netlink.c
> @@ -142,7 +142,8 @@ static void sti_netlink_receive(struct s
> static int __init sti_netlink_init(void)
> {
> sti_sock = netlink_kernel_create(NETLINK_USERSOCK, 0,
> - sti_netlink_receive, THIS_MODULE);
> + sti_netlink_receive, NULL,
> + THIS_MODULE);
> if (!sti_sock) {
> printk(KERN_ERR "STI: Failed to create netlink socket\n");
> return -ENODEV;
>
Thanks, pushing today.
Tony
next prev parent reply other threads:[~2007-05-08 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070508200109.272063491@pwsan.com>
2007-05-08 20:01 ` [PATCH] fix sti-netlink.c compilation failure Paul Walmsley
2007-05-08 21:39 ` Tony Lindgren [this message]
2007-05-08 23:31 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070508213939.GL32547@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox