[PATCH] fix ipt_IDLETIMER.c compilation

[PATCH] fix ipt_IDLETIMER.c compilation

[Paul Walmsley]

[-- Attachment #1: fix-ipt-idletimer.patch --]
[-- Type: text/plain, Size: 1600 bytes --]

Update net/ipv4/netfilter/ipt_IDLETIMER.c to compile after recent
changes to include/linux/netdevice.h (commit
4e9cac2ba437fcb093c7417b1cd91a77ebd1756a).  Compile-tested only.

  CC      net/ipv4/netfilter/ipt_IDLETIMER.o
net/ipv4/netfilter/ipt_IDLETIMER.c: In function 'utimer_notifier_call':
net/ipv4/netfilter/ipt_IDLETIMER.c:189: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
net/ipv4/netfilter/ipt_IDLETIMER.c: In function 'utimer_fini':
net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: 'dev_base' undeclared (first use in this function)
net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: (Each undeclared identifier is reported only once
net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: for each function it appears in.)
net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: 'struct net_device' has no member named 'next'
make[3]: *** [net/ipv4/netfilter/ipt_IDLETIMER.o] Error 1


Signed-off-by: Paul Walmsley <paul@pwsan.com>

---
 net/ipv4/netfilter/ipt_IDLETIMER.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-omap-2.6/net/ipv4/netfilter/ipt_IDLETIMER.c
===================================================================
--- linux-omap-2.6.orig/net/ipv4/netfilter/ipt_IDLETIMER.c
+++ linux-omap-2.6/net/ipv4/netfilter/ipt_IDLETIMER.c
@@ -219,7 +219,7 @@ static void utimer_fini(void)
 
 	rtnl_lock();
 	unregister_netdevice_notifier(&utimer_notifier_block);
-	for (dev = dev_base; dev; dev = dev->next)
+	for_each_netdev(dev)
 		utimer_notifier_call(&utimer_notifier_block,
 				     NETDEV_DOWN, dev);
 	rtnl_unlock();

-- 

Re: [PATCH] fix ipt_IDLETIMER.c compilation

[Tony Lindgren]

* Paul Walmsley <paul@pwsan.com> [070508 14:03]:
> Update net/ipv4/netfilter/ipt_IDLETIMER.c to compile after recent
> changes to include/linux/netdevice.h (commit
> 4e9cac2ba437fcb093c7417b1cd91a77ebd1756a).  Compile-tested only.
> 
>   CC      net/ipv4/netfilter/ipt_IDLETIMER.o
> net/ipv4/netfilter/ipt_IDLETIMER.c: In function 'utimer_notifier_call':
> net/ipv4/netfilter/ipt_IDLETIMER.c:189: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
> net/ipv4/netfilter/ipt_IDLETIMER.c: In function 'utimer_fini':
> net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: 'dev_base' undeclared (first use in this function)
> net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: (Each undeclared identifier is reported only once
> net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: for each function it appears in.)
> net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: 'struct net_device' has no member named 'next'
> make[3]: *** [net/ipv4/netfilter/ipt_IDLETIMER.o] Error 1
> 
> 
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> 
> ---
>  net/ipv4/netfilter/ipt_IDLETIMER.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-omap-2.6/net/ipv4/netfilter/ipt_IDLETIMER.c
> ===================================================================
> --- linux-omap-2.6.orig/net/ipv4/netfilter/ipt_IDLETIMER.c
> +++ linux-omap-2.6/net/ipv4/netfilter/ipt_IDLETIMER.c
> @@ -219,7 +219,7 @@ static void utimer_fini(void)
>  
>  	rtnl_lock();
>  	unregister_netdevice_notifier(&utimer_notifier_block);
> -	for (dev = dev_base; dev; dev = dev->next)
> +	for_each_netdev(dev)
>  		utimer_notifier_call(&utimer_notifier_block,
>  				     NETDEV_DOWN, dev);
>  	rtnl_unlock();
> 
> -- 

Pushing this one too.

Tony