Re: [PATCH] Resubmitting TWL4030 GPIO driver

[Tony Lindgren <tony@atomide.com>]

Hi,

* Syed Mohammed, Khasim <x0khasim@ti.com> [070508 12:29]:
> After Incorporating Review comments.
> 
> This adds TWL4030 GPIO driver support. Required for TWL4030 Keypad and other
> TWL4030 GPIO dependent modules.

...

> +/*
> + * twl4030 GPIO request function
> + */
> +int twl4030_request_gpio(int gpio)
> +{
> +	int ret = 0;
> +
> +	if (unlikely(gpio >= TWL4030_GPIO_MAX)) {
> +		return -EPERM;
> +	}
> +
> +	down(&gpio_sem);
> +	if (gpio_usage_count & (0x1 << gpio)) {
> +		ret = -EBUSY;
> +	} else {
> +		u8 clear_pull[6] = { 0, 0, 0, 0, 0, 0 };
> +		/* First time usage? - switch on GPIO module */
> +		if (!gpio_usage_count) {
> +			ret =
> +			gpio_twl4030_write(REG_GPIO_CTRL,
> +					MASK_GPIO_CTRL_GPIO_ON);
> +			ret = gpio_twl4030_write(REG_GPIO_SIH_CTRL, 0x00);
> +		}
> +		if (!ret) {
> +			gpio_usage_count |= (0x1 << gpio);
> +		}
> +		ret =
> +		twl4030_i2c_write(TWL4030_MODULE_GPIO, clear_pull,
> +				REG_GPIOPUPDCTR1, 5);
> +	}
> +	up(&gpio_sem);
> +	return ret;
> +}

Can you please remove the unnecessary braces used for one liners
throughout the code?

This is something that will cause comments when trying to send this
to I2C list. Ideally all the new patches we integrate will be ready
be sent upstream also :)

Tony