* [PATCH] fix sti-netlink.c compilation failure
[not found] <20070508200109.272063491@pwsan.com>
@ 2007-05-08 20:01 ` Paul Walmsley
2007-05-08 21:39 ` Tony Lindgren
2007-05-08 23:31 ` Paul Mundt
0 siblings, 2 replies; 3+ messages in thread
From: Paul Walmsley @ 2007-05-08 20:01 UTC (permalink / raw)
To: linux-omap-open-source
[-- Attachment #1: sti-netlink-compilation-fix.patch --]
[-- Type: text/plain, Size: 1338 bytes --]
Fix this compilation error in current linux-omap-2.6 git head:
CC arch/arm/plat-omap/sti/sti-netlink.o
arch/arm/plat-omap/sti/sti-netlink.c: In function 'sti_netlink_init':
arch/arm/plat-omap/sti/sti-netlink.c:145: warning: passing argument 4 of 'netlink_kernel_create' from incompatible pointer type
arch/arm/plat-omap/sti/sti-netlink.c:145: error: too few arguments to function 'netlink_kernel_create'
make[2]: *** [arch/arm/plat-omap/sti/sti-netlink.o] Error 1
make[1]: *** [arch/arm/plat-omap/sti] Error 2
make: *** [arch/arm/plat-omap] Error 2
Compile-tested only.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
arch/arm/plat-omap/sti/sti-netlink.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-omap-2.6/arch/arm/plat-omap/sti/sti-netlink.c
===================================================================
--- linux-omap-2.6.orig/arch/arm/plat-omap/sti/sti-netlink.c
+++ linux-omap-2.6/arch/arm/plat-omap/sti/sti-netlink.c
@@ -142,7 +142,8 @@ static void sti_netlink_receive(struct s
static int __init sti_netlink_init(void)
{
sti_sock = netlink_kernel_create(NETLINK_USERSOCK, 0,
- sti_netlink_receive, THIS_MODULE);
+ sti_netlink_receive, NULL,
+ THIS_MODULE);
if (!sti_sock) {
printk(KERN_ERR "STI: Failed to create netlink socket\n");
return -ENODEV;
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix sti-netlink.c compilation failure
2007-05-08 20:01 ` [PATCH] fix sti-netlink.c compilation failure Paul Walmsley
@ 2007-05-08 21:39 ` Tony Lindgren
2007-05-08 23:31 ` Paul Mundt
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2007-05-08 21:39 UTC (permalink / raw)
To: Paul Walmsley; +Cc: linux-omap-open-source
* Paul Walmsley <paul@pwsan.com> [070508 13:04]:
> Fix this compilation error in current linux-omap-2.6 git head:
>
> CC arch/arm/plat-omap/sti/sti-netlink.o
> arch/arm/plat-omap/sti/sti-netlink.c: In function 'sti_netlink_init':
> arch/arm/plat-omap/sti/sti-netlink.c:145: warning: passing argument 4 of 'netlink_kernel_create' from incompatible pointer type
> arch/arm/plat-omap/sti/sti-netlink.c:145: error: too few arguments to function 'netlink_kernel_create'
> make[2]: *** [arch/arm/plat-omap/sti/sti-netlink.o] Error 1
> make[1]: *** [arch/arm/plat-omap/sti] Error 2
> make: *** [arch/arm/plat-omap] Error 2
>
> Compile-tested only.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
>
> ---
> arch/arm/plat-omap/sti/sti-netlink.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-omap-2.6/arch/arm/plat-omap/sti/sti-netlink.c
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/plat-omap/sti/sti-netlink.c
> +++ linux-omap-2.6/arch/arm/plat-omap/sti/sti-netlink.c
> @@ -142,7 +142,8 @@ static void sti_netlink_receive(struct s
> static int __init sti_netlink_init(void)
> {
> sti_sock = netlink_kernel_create(NETLINK_USERSOCK, 0,
> - sti_netlink_receive, THIS_MODULE);
> + sti_netlink_receive, NULL,
> + THIS_MODULE);
> if (!sti_sock) {
> printk(KERN_ERR "STI: Failed to create netlink socket\n");
> return -ENODEV;
>
Thanks, pushing today.
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix sti-netlink.c compilation failure
2007-05-08 20:01 ` [PATCH] fix sti-netlink.c compilation failure Paul Walmsley
2007-05-08 21:39 ` Tony Lindgren
@ 2007-05-08 23:31 ` Paul Mundt
1 sibling, 0 replies; 3+ messages in thread
From: Paul Mundt @ 2007-05-08 23:31 UTC (permalink / raw)
To: Paul Walmsley; +Cc: linux-omap-open-source
On Tue, May 08, 2007 at 02:01:10PM -0600, Paul Walmsley wrote:
> Fix this compilation error in current linux-omap-2.6 git head:
>
> CC arch/arm/plat-omap/sti/sti-netlink.o
> arch/arm/plat-omap/sti/sti-netlink.c: In function 'sti_netlink_init':
> arch/arm/plat-omap/sti/sti-netlink.c:145: warning: passing argument 4 of 'netlink_kernel_create' from incompatible pointer type
> arch/arm/plat-omap/sti/sti-netlink.c:145: error: too few arguments to function 'netlink_kernel_create'
> make[2]: *** [arch/arm/plat-omap/sti/sti-netlink.o] Error 1
> make[1]: *** [arch/arm/plat-omap/sti] Error 2
> make: *** [arch/arm/plat-omap] Error 2
>
> Compile-tested only.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
>
Looks reasonable.
Acked-by: Paul Mundt <lethal@linux-sh.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-05-08 23:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070508200109.272063491@pwsan.com>
2007-05-08 20:01 ` [PATCH] fix sti-netlink.c compilation failure Paul Walmsley
2007-05-08 21:39 ` Tony Lindgren
2007-05-08 23:31 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox