From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 0/5] Clean up omap24xx.h symbolic constants Date: Thu, 17 May 2007 11:14:23 -0700 Message-ID: <20070517181423.GD8556@atomide.com> References: <20070517174328.GB8556@atomide.com> <9C23CDD79DA20A479D4615857B2E2C47F15ADB@dlee13.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <9C23CDD79DA20A479D4615857B2E2C47F15ADB@dlee13.ent.ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: "Syed Mohammed, Khasim" Cc: Paul Walmsley , linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org * Syed Mohammed, Khasim [070517 10:54]: > Hi: > > IMHO, using of SDRC_BASE as well as CTRL_BASE, PRCM_BASE etc., > >> can lead to name collision, the names is not so unique as may > >> seem. I suggest using of OMAP_ prefix for these names. > > > >Good point. We could use OMAP_ prefix and in case of conflicts > >with omap1 defines, we could rename them to have OMAP1_ prefix. > > > > When we started with 3430 developments we had similar issues. Our approach was, > > OMAP3_prefix : If the Macro is defined and valid for 3430 only > OMAP2_prefix : If its valid only for OMAP2 > OMAP242x_prefix : for 2420 specific > OMAP243x_prefix : for 2430 specific > OMAP1_prefix : for all OMAP1 platforms, but we didn't change any, thinking it might break previous programs. > OMAP_prefix : Generic for all OMAP platforms. > > It's better if we follow some kind of standard and pass it as a review comment for any patches from now on. Maybe just use OMAP2_ prefix for defines common to all omaps >= 2 until we have have to rename some registers again? Anybody have better ideas? > Other alternative is to use Peripheral version in OMAP. Example: > > OMAP1 has DMA version 3 > OMAP2 has DMA version 4 > OMAP3 has DMA version 4 > > So define a macro for DMA as > > OMAP_DMA3_yyyyyy : for all OMAPs where DMA version 3 is used (like OMAPV1030, OMAP1710, OMAP1610, etc) > > OMAP_DMA4_yyyyyy : for all OMAPs where DMA version 4 is used (like OMAP3430 2430 2420, etc). > > Similar thing can be adopted for SPI, McBSP, I2C, and other peripherals of OMAP. Yeah this should be used where possible to keep the drivers working. I think omap I2C driver is already doing it. Regards, Tony